feat: simplify deeplink updates, use cloudflare worker #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainbicycle
changed the title
damassi
reviewed
Oct 24, 2024
| await worker.stop(); | ||
| }); | ||
|
|
||
| it("should return the apple-app-site-association JSON on the correct route", async () => { |
There was a problem hiding this comment.
Nice @brainbicycle - I couldn't quite figure out how to test that other worker in MP 👌
There was a problem hiding this comment.
Yeah i thought this was gonna be a pain but was pleasantly surprised! https://developers.cloudflare.com/workers/wrangler/api/
There was a problem hiding this comment.
Oh I tried to get some basic test going in Metaphysics but was unsuccessful... possibly due to the worker's usage of the cache API.
damassi
approved these changes
Oct 24, 2024
joeyAghion
approved these changes
Oct 28, 2024
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://artsyproduct.atlassian.net/browse/PHIRE-1143
Implements RFC here: https://www.notion.so/artsy/Simplify-universal-link-config-updates-fffcab0764a0804bbf32d730ee4ed134
Updates this repo to stop distributing a library to be consumed by clients.
Instead we will use the same cloudflare worker to distribute app-site-association and assetlinks for deeplinks on every url we need. Deployment will be similar to other repos, deploy to staging* (test worker) on merge to main, deploy to production using deploy prs.
Implementation details:
Follow-ups