Sailthru script fix, and updates #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashfurrow
commented
Feb 28, 2020
| @@ -47,7 +47,7 @@ function isNotSailthruPattern(pattern) { | |||
| */ | |||
| function encodePattern(pattern) { | |||
| const path = pattern.match(/^NOT (.+)$/)[1] | |||
| const encoded = encodePath(path.slice(0, -(path.length % 3))) | |||
| const encoded = encodePath(path.slice(0, path.length - (path.length % 3))) | |||
There was a problem hiding this comment.
This is the fix. The docs for slice() describe how it works when the argument is negative – it's a shorthand for what I've written out here. The bug was that, if path.length is exactly a multiple of 3, then -(path.length % 3) evaluates to -0, and slice() returns "".
There was a problem hiding this comment.
that's a hell of a bugfix @ashfurrow 👍
dleve123
approved these changes
Feb 28, 2020
| @@ -47,7 +47,7 @@ function isNotSailthruPattern(pattern) { | |||
| */ | |||
| function encodePattern(pattern) { | |||
| const path = pattern.match(/^NOT (.+)$/)[1] | |||
| const encoded = encodePath(path.slice(0, -(path.length % 3))) | |||
| const encoded = encodePath(path.slice(0, path.length - (path.length % 3))) | |||
There was a problem hiding this comment.
that's a hell of a bugfix @ashfurrow 👍
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Sailthru url-encoding script, as well as adds the
log_inandsign_uppaths to the excluded list. I noticed this was opened in a crash that inexplicably caused a stack overflow. I don't understand it, but in any case, we shouldn't be linking into the app on these URLs because the app doesn't know how to route them correctly. /cc @ds300I'll inline an explanation of the script fix, since Prettier made the changes hard to isolate.