FX-1738: only exclude collection hubs from the iOS app #27
Conversation
xtina-starr
force-pushed
the
exclude-collection-hubs-from-ios-app
branch
from
0d9692b
to
9a3dfdf
Compare
apple-app-site-association.json
Outdated
| "NOT *L3ZpZGVv*", | ||
| "NOT *L25l*", | ||
| "NOT *L25ld3Mv*", | ||
| "NOT **", |
There was a problem hiding this comment.
I don't know why these keep showing up in the file, but we should remove NOT ** entries.
There was a problem hiding this comment.
This is a bug in the yarn build script for this repo. Just got these extraneous NOT ** after running it.
There was a problem hiding this comment.
Yeah, I need to dig into that 😅
xtina-starr
changed the title
xtina-starr
force-pushed
the
exclude-collection-hubs-from-ios-app
branch
from
d3de470
to
ea3f67d
Compare
apple-app-site-association.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "activitycontinuation": { | |||
| "activity ntinuation": { | |||
There was a problem hiding this comment.
This seems like an accidental deletion of some characters.
There was a problem hiding this comment.
Aww good catch!
| @@ -25,8 +25,6 @@ | |||
| "NOT /2016-year-in-art", | |||
| "NOT /venice-biennale*", | |||
| "NOT /gender-equality*", | |||
| "NOT /collections", | |||
There was a problem hiding this comment.
Did we build this index view in the app? I think we'll still want users to see the web version of this (but could totally be missing something).
There was a problem hiding this comment.
+1 I think we still want to keep this line for now.
There was a problem hiding this comment.
Good catch. I just corrected it.
* commits output of `yarn build`, but removing `NOT **` entries which aren't desirable. See [this GH comment][0]. [0]:#27 (comment)
|
🚀 PR was released in |
Addresses: FX-1738 and FX-1739
This remove the rule to exclude all collections pages from being shown in the iOS app
and scopes it down to just exclude department (hub) collections. I addresses some merge conflicts in this PR so I'd appreciate it the reviewers took extra care to look at that as well.Once this is merged we will need to update the dependencies that use this library:
*Updates to Sailthru requires you to notify Sailthru support and provide them with the updated
apple-app-site-association.jsonfile.