Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing comparison for finding path point closest to final trajectories #105

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

SteveMacenski
Copy link
Collaborator

This is a pretty significant bug I found while writing unit tests. It seemed worth bringing here immediately rather than waiting

@SteveMacenski
Copy link
Collaborator Author

SteveMacenski commented Dec 6, 2022

Requires some testing when I'm back at my desk to see how this impacts the system. If the value used from here was ever used (e.g. if path align ever called after the other path critics) then that would serious change the path tracking behavior and offsetting logic. Could actually be contributing to other issues since it impacts the 3 path critics + anything involving path ratio

See if this was contributing to the short cutting (or if we can do something about that shortcutting)

@SteveMacenski
Copy link
Collaborator Author

SteveMacenski commented Dec 8, 2022

  • test changes - shouldn't impact in this branch because it shouldn't have been called -- check that.
  • Retune -- if called and impacted the system
  • change default order of plugins so that path align is always first to get from plugin foremost (lower compute)

@SteveMacenski SteveMacenski merged commit c045b9d into infomatics Dec 8, 2022
@SteveMacenski SteveMacenski deleted the SteveMacenski-patch-1 branch December 8, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant