Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support read C++ standard via CMAKE_CXX_STANDARD when compiling Python bindings #275

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jul 5, 2023

Fix #274 . Due to the need of supporting pybind11, I always default to use the C++11 standard unless the user specify CMAKE_CXX_STANDARD, even if the compiler standard version is different from C++11, such as C++17 for GCC11.

I also added a pybind11-cmake job on Ubuntu 20.04 to ensure that the compilation works fine with pybind11 2.4.3 .

@traversaro traversaro closed this Jul 5, 2023
@traversaro traversaro reopened this Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #275 (905e919) into devel (bc1e90f) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 905e919 differs from pull request most recent head 2e4a798. Consider uploading reports for the commit 2e4a798 to get more accurate results

@@            Coverage Diff             @@
##            devel     #275      +/-   ##
==========================================
- Coverage   97.96%   97.96%   -0.01%     
==========================================
  Files          55       55              
  Lines        1818     1817       -1     
==========================================
- Hits         1781     1780       -1     
  Misses         37       37              

@traversaro
Copy link
Contributor Author

traversaro commented Jul 6, 2023

The PR is ready for review. The decrease in code coverage I think it is spurious, while I am not sure about the pybind11-cmake step hanging, probably given that I changed that step there is something not matching between devel and the PR branch (and the job is required?), but I would expect everything to work fine once the PR is merged.

@artivis artivis merged commit bb3f675 into artivis:devel Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support specifying C++ standard from CMake command line when compiling Python bindings
2 participants