Support read C++ standard via CMAKE_CXX_STANDARD when compiling Python bindings #275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #274 . Due to the need of supporting pybind11, I always default to use the C++11 standard unless the user specify
CMAKE_CXX_STANDARD
, even if the compiler standard version is different from C++11, such as C++17 for GCC11.I also added a pybind11-cmake job on Ubuntu 20.04 to ensure that the compilation works fine with pybind11 2.4.3 .