Improve performance of runSnippetCursor
#323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes
runSnippetCursor
inrun_snippet.ts
by reducing redundant calls toview.state.sliceDoc
.Partially solves #320 by improving the editting of large files.
Performance Testing
Tested with a large markdown file generated with the following command:
Pushed a key when the cursor is at the bottom of the file and measured the time spent handling the keydown event using DevTools.
Test Environment:
Results:
runSnippetCursor
consuming 47ms.runSnippetCursor
consuming 0.2ms.