Some improvements to plugin initialization #322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
npm audit fix
.sortSnippets
calls in "main.ts". Snippets returned by the functionparseSnippets
are already sorted.refreshCMExtensions
and renamed it tosetEditorExtensions
.this.app.workspace.updateOptions
outside of the function so that its side effect is limited to modifyingthis.editorExtensions
.latexSuiteExtensions
andoptionalExtensions
. The previous code feels hacky because it required@ts-ignore
. In addition, I found the namelatexSuiteExtensions
unclear.reconfigureLatexSuiteConfig
inprocessSettings
. The extensions reconfigured byreconfigureLatexSuiteConfig
will be removed in the call torefreshCMExtensions
(setEditorExtensions
in new code), soreconfigureLatexSuiteConfig
is unnecessary.