-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Improve decomission process #430
Conversation
@@ -32,3 +32,6 @@ insecurely_log_authkey: false | |||
# Whether to store hashed authkey in state | |||
# Setting to false won't re-run 'tailscale up' on authkey change | |||
auth_key_in_state: true | |||
# Whether to purge state on uninstall | |||
# Setting to true will clean up the state folder /var/lib/tailscale | |||
tailscale_purge_state: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to handle this differently, let's exclude adding a variable in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will create another PR.
Because current changes are actively in use :)
I will create another PR. |
Often, when I run the role with
state: absent
, the next role run withstate: present
will fail with different errors like described in the bug#429
After talking to Tailscale support, that might happen if
/var/lib/tailscale/
still contains the previous machine identity (auth key, id, etc).We have to remove this folder during decommission.
Fortunately, Ubuntu package has that task inside the
tailscale.postrm
, (if the user runeapt purge tailscale
):So, this is the best way to handle tailscale state removal -
purge: true,
because this will always be aligned with the package maintainers config.I am not sure about other distros, though.
Probably, we need a task like this in each distro subtree:
@artis3n , please let me know how you prefer to handle this.