Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Qlora scripts on Intel GPUs #219

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

abhilash1910
Copy link
Contributor

Motivation:

  • Thanks for the qlora repo, this PR is for adding intel gpu support for quantized inference in the qlora script.
  • There is an internal progress on B&B enabling for intel gpus which will make the support complete.

@artidoro could you please review . Would appreciate your thoughts on this. Thanks

Copy link
Owner

@artidoro artidoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

qlora.py Outdated Show resolved Hide resolved
@abhilash1910
Copy link
Contributor Author

@artidoro requesting re-review , let me know if any changes needed else can this be merged?

@artidoro
Copy link
Owner

So it looks good to me, however, I cannot test the code as I don't have an Intel GPU. Could you let me know how you verified that it works?
@TimDettmers do you have thoughts on adding this to the repo? It could be helpful to people using Intel GPUs and it seems relatively few changes.

@abhilash1910
Copy link
Contributor Author

@artidoro @TimDettmers at Intel we are planning to integrate our kernel code for the quantization cu kernels . This is a work in progress internally and after validation I will flag a PR at b&b. The pythonic frontend (here) has relatively easier changes but the core of the task is in the kernel adaptation for our gpu devices which we are integrating.

@artidoro
Copy link
Owner

Sounds good! I am happy to merge this PR. Might be useful to add some documentation too.

@artidoro artidoro merged commit 76d8664 into artidoro:main Jul 24, 2023
LagPixelLOL pushed a commit to LagPixelLOL/qlora that referenced this pull request Feb 8, 2024
Enable Qlora scripts on Intel GPUs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants