Remove dependency on quickcheck_macros
#245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `macro_rules` macro `quickcheck::quickcheck` is the preferred way to use `quickcheck` in tests. The crate author is not a user of the `syn`-based `quickcheck_macros` attribute macro. This dep has atrophied and has not been updated to `syn` v2. Remove the attribute macro and replace its use with the equivalent `macro_rules` macro. Update minimum bound on `version-sync` to v0.9.5. These changes combine to fix the duplicate crate warnings found by `cargo-deny` on trunk: ``` error[duplicate]: found 2 duplicate entries for crate 'syn' ┌─ /github/workspace/Cargo.lock:23:1 │ 23 │ ╭ syn 1.0.109 registry+https://github.com/rust-lang/crates.io-index 24 │ │ syn 2.0.32 registry+https://github.com/rust-lang/crates.io-index │ ╰────────────────────────────────────────────────────────────────^ lock entries │ = syn v1.0.109 └── quickcheck_macros v1.0.0 └── (dev) intaglio v1.9.1 = syn v2.0.32 └── version-sync v0.9.5 └── (dev) intaglio v1.9.1 ```
lopopolo
force-pushed
the
lopopolo/syn-v2
branch
from
5ac2cd8 to
c424a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
macro_rulesmacroquickcheck::quickcheckis the preferred way to usequickcheckin tests. The crate author is not a user of thesyn-basedquickcheck_macrosattribute macro. This dep has atrophied and has not been updated tosynv2.Remove the attribute macro and replace its use with the equivalent
macro_rulesmacro. Update minimum bound onversion-syncto v0.9.5.These changes combine to fix the duplicate crate warnings found by
cargo-denyon trunk:Fixes build failure in https://github.com/artichoke/intaglio/actions/runs/6153154527/job/16696558548.
This diff is best viewed when ignoring whitespace.