Merge pull request #196 from artichoke/lopopolo/clippy-useless-asref

Address `clippy::useless_asref` lint violations
artichoke · Jan 17, 2024 · a1484d2 · a1484d2
2 parents 21c18ed + 9abf9a0
commit a1484d2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/doc/implementing_self_referential_data_structures.rs b/src/doc/implementing_self_referential_data_structures.rs
@@ -31,7 +31,7 @@
 //!             Rc::unadopt(&head, tail);
 //!             Rc::unadopt(tail, &head);
 //!
-//!             tail.borrow_mut().next = next.as_ref().map(Rc::clone);
+//!             tail.borrow_mut().next = next.clone();
 //!             if let Some(ref next) = next {
 //!                 unsafe {
 //!                     Rc::adopt_unchecked(tail, next);
@@ -42,7 +42,7 @@
 //!             Rc::unadopt(&head, next);
 //!             Rc::unadopt(next, &head);
 //!
-//!             next.borrow_mut().prev = tail.as_ref().map(Rc::clone);
+//!             next.borrow_mut().prev = tail.clone();
 //!             if let Some(ref tail) = tail {
 //!                 unsafe {
 //!                     Rc::adopt_unchecked(next, tail);

diff --git a/tests/leak_doubly_linked_list.rs b/tests/leak_doubly_linked_list.rs
@@ -25,7 +25,7 @@ impl<T> List<T> {
             Rc::unadopt(&head, tail);
             Rc::unadopt(tail, &head);
 
-            tail.borrow_mut().next = next.as_ref().map(Rc::clone);
+            tail.borrow_mut().next = next.clone();
             if let Some(ref next) = next {
                 unsafe {
                     Rc::adopt_unchecked(tail, next);
@@ -36,7 +36,7 @@ impl<T> List<T> {
             Rc::unadopt(&head, next);
             Rc::unadopt(next, &head);
 
-            next.borrow_mut().prev = tail.as_ref().map(Rc::clone);
+            next.borrow_mut().prev = tail.clone();
             if let Some(ref tail) = tail {
                 unsafe {
                     Rc::adopt_unchecked(next, tail);