Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: is it possible to add custom libraries not included in the build script #28

Closed
dvscode opened this issue Apr 20, 2021 · 6 comments
Assignees
Labels
android Affect Android platform apple Affect Apple platforms enhancement New feature or request fixed Fixed in main branch no-issue-activity scripts Affect build scripts

Comments

@dvscode
Copy link

dvscode commented Apr 20, 2021

Is your feature request related to a problem? Please describe.
We want to use ffmpeg library for SRT streaming

Describe the solution you'd like
When compiling library for android we can specify --enable-srt to add SRT module (https://github.com/Haivision/srt.git)

Platform
Would be great to have on all platforms

Additional context
Here is how it's enabled when compiling ffmpeg https://medium.com/@eyevinntechnology/using-ffmpeg-and-srt-to-transport-video-signal-to-the-cloud-7160960f846a

@tanersener
Copy link
Collaborator

Unfortunately, srt depends on openssl and the license of openssl is not compatible with LGPL / GPL. See tanersener/mobile-ffmpeg#81.

@tanersener tanersener added the enhancement New feature or request label Apr 20, 2021
@tanersener tanersener self-assigned this Apr 20, 2021
@dvscode
Copy link
Author

dvscode commented Apr 20, 2021

@tanersener thank you for fast reply. As you mentioned in linked post, you were waiting for the openssl license to change? According to https://www.openssl.org/source/license.html looks like openssl v3.0 now licensed under Apache v2. does this mean we might have a chance to see libsrt support?

@tanersener
Copy link
Collaborator

Yes, when openssl 3.0 is stable enough we can add support for it. Unfortunately, the current 3.0.0 version is not even in beta. The last release they published is 3.0.0-alpha14.

@tanersener tanersener added scripts Affect build scripts android Affect Android platform apple Affect Apple platforms labels May 1, 2021
@github-actions
Copy link

github-actions bot commented Jul 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this as completed Jul 9, 2021
@tanersener tanersener added the wontfix This will not be worked on label Jul 9, 2021
@Fanfwe
Copy link

Fanfwe commented Oct 30, 2021

SRT now has support for building against 3 different crypto libraries: openssl, gnutls and mbedtls.
gnutls is LGPL and mbedtls is Apache-2.0 so it sounds like there's a way forward, potentially.

@tanersener
Copy link
Collaborator

A few updates regarding some of the questions asked in this thread:

  • Building custom libraries is implemented in the build scripts. See Building FFmpeg Kit with Custom Libraries wiki page
  • Openssl 3.0 support is added. However, there are issues regarding building openssl on 32-bit iOS architectures and on tvOS. Because of those problems, openssl won't replace gnutls yet. They are already reported on openssl github page. It must be fixed on their end. Until then openssl will stay partially supported
  • srt support is also added, but it relies on openssl. So, it cannot be built on the architectures where we can't build openssl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Affect Android platform apple Affect Apple platforms enhancement New feature or request fixed Fixed in main branch no-issue-activity scripts Affect build scripts
Projects
None yet
Development

No branches or pull requests

3 participants