Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement chapters in MediaInformation class for all platforms #196

Closed
tanersener opened this issue Oct 20, 2021 · 1 comment
Closed

Implement chapters in MediaInformation class for all platforms #196

tanersener opened this issue Oct 20, 2021 · 1 comment
Assignees
@tanersener
Labels
android Affect Android platform apple Affect Apple platforms enhancement New feature or request fixed-in-v4.5.1 flutter Affect flutter platform library Affects the library react-native Affect react-native platform v4.5 Affects v4.5 release

Comments

@tanersener
Copy link
Collaborator

It was implemented for Flutter in https://github.com/tanersener/ffmpeg-kit/pull/182. We must apply this in all platforms to have the same API across all platforms.
@tanersener tanersener added enhancement New feature or request android Affect Android platform apple Affect Apple platforms flutter Affect flutter platform react-native Affect react-native platform library Affects the library v4.5 Affects v4.5 release labels Oct 20, 2021
tanersener added a commit that referenced this issue Dec 19, 2021
@tanersener
updates chapters in media information object, improves #196
aed46e9
tanersener added a commit that referenced this issue Dec 19, 2021
@tanersener
adds chapters in media information object, fixes #196
c80244e
tanersener added a commit that referenced this issue Dec 19, 2021
@tanersener
adds chapters in media information object, fixes #196
b8ff0d5
@tanersener tanersener self-assigned this Dec 19, 2021
@tanersener
Copy link
Collaborator Author

Fixed in the development branches.

@tanersener tanersener added the fixed-on-development Fixed on the development branch. Not released yet. label Dec 19, 2021
@tanersener tanersener added fixed-in-v4.5.1 and removed fixed-on-development Fixed on the development branch. Not released yet. labels Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanersener tanersener

Labels
android Affect Android platform apple Affect Apple platforms enhancement New feature or request fixed-in-v4.5.1 flutter Affect flutter platform library Affects the library react-native Affect react-native platform v4.5 Affects v4.5 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tanersener