Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OPERATOR_WATCH_NAMESPACE - duplicate of SDK env var WATCH_NAMESPACE #266

Open
gtully opened this issue Jul 6, 2022 · 0 comments
Open

Remove OPERATOR_WATCH_NAMESPACE - duplicate of SDK env var WATCH_NAMESPACE #266

gtully opened this issue Jul 6, 2022 · 0 comments
Assignees
@Msarawan
Labels
enhancement New feature or request

Comments

@gtully
Copy link
Contributor

gtully commented Jul 6, 2022 •
edited
Loading

With the watch namesace support in the sdk, and with no evidence of this env var being used, lets remove as it now duplicates WATCH_NAMESPACE
Worst case scenario a user can add a kube env var that references WATCH_NAMESPACE

The NAMESPACE env var, that is not a duplicate, maybe we leave that one in place, but again, who uses it and why?
@gtully gtully added the enhancement New feature or request label Jul 6, 2022
@gtully gtully assigned RoddieKieley and unassigned RoddieKieley Jul 6, 2022
lavocatt added a commit to lavocatt/activemq-artemis-operator that referenced this issue Apr 11, 2024
@lavocatt
[artemiscloud#266] use WATCH_NAMESPACE
522909c 
Replace the custom env variable OPERATOR_WATCH_NAMESPACE with
WATCH_NAMESPACE.
@Msarawan Msarawan self-assigned this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Msarawan Msarawan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gtully @RoddieKieley @Msarawan