Add secondary OIDC provider capability #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to define more than one OIDC provider in AM. Specific providers can be chosen using HTTP query params passed to the server when authenticating.
Add a new setting to control whether local AMSS authentication is available when OIDC authentication is in use. If local AM authentication is disabled, then users will only be able to authenticate via the OIDC provider. If the new setting is not configured, local AM authentication is available.
replaceafill
force-pushed
the
dev/oidc-enhancements-for-sso
branch
from
2e9c78a
to
e08928e
Compare
If the OIDC_ALLOW_LOCAL_AUTHENTICATION setting denies local authentication, users should not be able to authenticate even if they access the local login form directly.
replaceafill
force-pushed
the
dev/oidc-enhancements-for-sso
branch
from
24eed2e
to
f5365ab
Compare
replaceafill
force-pushed
the
dev/oidc-enhancements-for-sso
branch
from
f5365ab
to
1735764
Compare
sbreker
commented
Oct 4, 2024
There was a problem hiding this comment.
Looks great @replaceafill! 👍
Curious why you chose to hard code LOGIN_URL = "/oidc/authenticate/"?
@sbreker sorry I forgot to include the explanation in the commit. During manual testing I noticed the See where theoidc_authentication_init pattern is converted into a string and the middleware redirects you to an nonexistent /oidc_authentication_init URL instead.
The Dashboard doesn't have this problem, but I decided to keep the values consistent for now. |
replaceafill
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to define more than one OIDC provider in AM. Specific providers can be chosen using HTTP query params passed to the server when authenticating.