Filter active users to send email notifications #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhwaniartefact
force-pushed
the
dev/issue-inactive-users-receive-emails
branch
from
20c77c4
to
c873d64
Compare
There was a problem hiding this comment.
@Dhwaniartefact @amayita the linked issue mentions fixity report emails specifically but this change is going to affect deletion requests emails too.
Is that intended? Should that be filed and implemented as a different issue and PR?
replaceafill
approved these changes
May 28, 2024
There was a problem hiding this comment.
This looks good @Dhwaniartefact. Please don't forget to adjust the commit message to reflect that you modified the behavior only for email notifications of the fixity check failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to archivematica/Issues#1523