-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JSON serialization for fixity failure report #713
Merged
Dhwaniartefact
merged 5 commits into
qa/0.x
from
dev/issue-trigger-signal-for-fixity-check
May 13, 2024
Merged
Fix JSON serialization for fixity failure report #713
Dhwaniartefact
merged 5 commits into
qa/0.x
from
dev/issue-trigger-signal-for-fixity-check
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaceafill
requested changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you first add a test that demonstrates the failure?
Dhwaniartefact
force-pushed
the
dev/issue-trigger-signal-for-fixity-check
branch
from
May 9, 2024 22:04
e0bf424
to
e2dcbb1
Compare
Dhwaniartefact
force-pushed
the
dev/issue-trigger-signal-for-fixity-check
branch
from
May 9, 2024 22:07
e2dcbb1
to
b82cade
Compare
replaceafill
requested changes
May 10, 2024
Dhwaniartefact
force-pushed
the
dev/issue-trigger-signal-for-fixity-check
branch
from
May 10, 2024 20:45
e820bb5
to
6cc2f26
Compare
Dhwaniartefact
force-pushed
the
dev/issue-trigger-signal-for-fixity-check
branch
from
May 10, 2024 20:47
6cc2f26
to
cbc6c46
Compare
replaceafill
requested changes
May 10, 2024
replaceafill
approved these changes
May 13, 2024
Dhwaniartefact
changed the title
Fix Json serialization for fixity failure report
Fix JSON serialization for fixity failure report
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.