Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: There is no way to filter package results by workflow status #989

Closed
fiver-watson opened this issue Jul 9, 2024 · 6 comments · Fixed by #1054
Closed

Problem: There is no way to filter package results by workflow status #989

fiver-watson opened this issue Jul 9, 2024 · 6 comments · Fixed by #1054

Comments

@fiver-watson
Copy link
Contributor

Description

One of the feedback elements from the recent Talk-Aloud usability tests. Currently users have no way of filtering package results by status. This can make it hard to find specific package when there are many results.

To Reproduce

1.Log in
2. Navigate to Packages
3. try to see only Done packages, or only those with Errors

Resulting error

No method available to filter results by workflow status

Expected behavior

Users can easily filter results by workflow status to better discover relevant packages.

Proposed solution

Following this feedback, we drafted 2 mockups to cover potential implementation solutions - one using tabs, and the other using a drop-down menu. After reviewing it with the team, no team members had strong preferences one way or the other. We then decided to get input from another Enduro user in a different context - Maaike, who operates the MoMA Enduro instance as part of their managed service.

Here is Maaike's feedback:

In my personal opinion, I prefer the Tabs option - I would find this a more efficient way to monitor the progress of a batch and view errors. The current status filter in [MoMA's version of] Enduro is similar to the drop-down filter option, which while functional, is slightly more tedious to manage than a series of tabs that I could quickly flip between.

Consequently we propose that the first implementation try using the tabs. A mockup is included below:

enduro-pkg-status-filter-tabs

@fiver-watson fiver-watson moved this to 🛠 Refining in Enduro Jul 9, 2024
@fiver-watson fiver-watson added the bug Something isn't working label Jul 9, 2024
@sallain sallain moved this from 🛠 Refining to 👍 Ready in Enduro Jul 11, 2024
@sallain sallain added SFA bridge work Client: SFA and removed bug Something isn't working Client: SFA labels Oct 2, 2024
@sallain
Copy link
Collaborator

sallain commented Oct 2, 2024

Note: #1036 allows for filtering by package status in the API; however, package filtering still needs to be implemented in the UI

@djjuhasz djjuhasz self-assigned this Oct 22, 2024
@djjuhasz djjuhasz moved this from 👍 Ready to ⏳ In Progress in Enduro Oct 22, 2024
djjuhasz added a commit that referenced this issue Oct 23, 2024
Add a package status filter select box to the Dashboard package list
page to allow filtering packages by status. Fixes #989.

Changes:
- Add a "filters" section to the package list page
- Add a "status" selector to the filters section
- Filter package list results when the "status" filter is changed
djjuhasz added a commit that referenced this issue Oct 23, 2024
Fixes #989.

Add a package status filter select box to the Dashboard package list
page to allow filtering packages by status.

Changes:
- Add a "filters" section to the package list page
- Add a "status" selector to the filters section
- Filter package list results when the "status" filter is changed
djjuhasz added a commit that referenced this issue Oct 24, 2024
Fixes #989.

Add a package status filter select box to the Dashboard package list
page to allow filtering packages by status.

Changes:
- Add a "filters" section to the package list page
- Add a "status" selector to the filters section
- Filter package list results when the "status" filter is changed
djjuhasz added a commit that referenced this issue Oct 24, 2024
Fixes #989.

Add a package status filter select box to the Dashboard package list
page to allow filtering packages by status.

Changes:
- Add a "filters" section to the package list page
- Add a "status" selector to the filters section
- Filter package list results when the "status" filter is changed
djjuhasz added a commit that referenced this issue Oct 24, 2024
Fixes #989.

Add a package status filter select box to the Dashboard package list
page to allow filtering packages by status.

Changes:
- Add a "filters" section to the package list page
- Add a "status" selector to the filters section
- Filter package list results when the "status" filter is changed
@djjuhasz djjuhasz linked a pull request Oct 24, 2024 that will close this issue
djjuhasz added a commit that referenced this issue Oct 24, 2024
Fixes #989.

Add a package status filter select box to the Dashboard package list
page to allow filtering packages by status.

Changes:
- Add a "Filters" section to the package list page
- Add a "Status" selector to the filters section
- Filter package list results when the "Status" filter is changed
djjuhasz added a commit that referenced this issue Oct 24, 2024
Fixes #989.

Add a package status filter select box to the Dashboard package list
page to allow filtering packages by status.

Changes:
- Add a "filters" section to the package list page
- Add a "status" selector to the filters section
- Filter package list results when the "status" filter is changed
djjuhasz added a commit that referenced this issue Oct 24, 2024
djjuhasz added a commit that referenced this issue Oct 24, 2024
djjuhasz added a commit that referenced this issue Oct 24, 2024
Fixes #989.

Add a package status filter select box to the Dashboard package list
page to allow filtering packages by status.

Changes:
- Add a "Filters" section to the package list page
- Add a "Status" selector to the filters section
- Filter package list results when the "Status" filter is changed
djjuhasz added a commit that referenced this issue Oct 25, 2024
djjuhasz added a commit that referenced this issue Oct 25, 2024
Fixes #989.

Add a package status filter select box to the Dashboard package list
page to allow filtering packages by status.

Changes:
- Add a "Filters" section to the package list page
- Add a "Status" selector to the filters section
- Filter package list results when the "Status" filter is changed
@github-project-automation github-project-automation bot moved this from ⏳ In Progress to 🎉 Done in Enduro Oct 25, 2024
djjuhasz added a commit that referenced this issue Oct 25, 2024
djjuhasz added a commit that referenced this issue Oct 29, 2024
djjuhasz added a commit that referenced this issue Oct 30, 2024
Refs #989.

Adapt the existing Tabs component to use it for filtering the package
list by status.

- Allow setting the package status filter by a "status" URL query
  parameter
- Update the "status" query parameter when clicking a filter tab
- Make the tab icons optional
- Include route parameters when checking if a tab is active
djjuhasz added a commit that referenced this issue Oct 30, 2024
Refs #989.

Adapt the existing Tabs component to filter the package list by status.

Changes:
- Make the dropdown package status filter a component to allow switching
  between dropdown and tab filters for A/B testing
- Allow setting the package status filter by a "status" URL query
  parameter
- Update the "status" query parameter when clicking a filter tab
- Make the tab icons optional
- Include query parameters when checking if a tab is active
djjuhasz added a commit that referenced this issue Oct 30, 2024
Refs #989.

Adapt the existing Tabs component to filter the package list by status.

Changes:
- Make the dropdown package status filter a component to allow switching
  between dropdown and tab filters for A/B testing
- Allow setting the package status filter by a "status" URL query
  parameter
- Update the "status" query parameter when clicking a filter tab
- Make the tab icons optional
- Include query parameters when checking if a tab is active
@fiver-watson
Copy link
Contributor Author

hi hi! Functionally, the tabs work great! However, I have a little bit of feedback on the design:

  • At minimum, it seems like there might have been an icon mixup? i would suggest swapping the icons for Error and In Progress

Image

  • Is it possible for me to browse the icon set you are using, and see what other options are available? I'd like to see if there are any alternative candidates. For example, though i can see that each is set to 24x24 size, it looks strange to me that the "Done" and "In progress" circle icons don't appear to be the same size. Also, if we can find something appropriate, it could be good to pick something for the All tab...

@jraddaoui
Copy link
Collaborator

jraddaoui commented Nov 13, 2024

@fiver-watson
Copy link
Contributor Author

fiver-watson commented Nov 13, 2024

Thanks @jraddaoui !

@djjuhasz some thoughts:

There are additional alternative options for each, but these seemed like the best picks to me. Open to other suggestions though!

@djjuhasz
Copy link
Collaborator

Updated icons:
image

@djjuhasz djjuhasz moved this from 🎉 Done to 🧐 QA in Enduro Nov 14, 2024
@fiver-watson
Copy link
Contributor Author

Nice! Thanks for doing that, @djjuhasz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🎉 Done
Development

Successfully merging a pull request may close this issue.

4 participants