Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make heartbeat timeouts and intervals configurable #612

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

DanielCosme
Copy link
Contributor

This PR will make configurable the activity heartbeats and throttle intervals in Temporal workflows.

@DanielCosme DanielCosme requested a review from jraddaoui May 31, 2024 14:02
Copy link
Member

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments @DanielCosme.

enduro.toml Outdated Show resolved Hide resolved
internal/workflow/policies.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
enduro.toml Outdated Show resolved Hide resolved
Copy link
Member

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DanielCosme!

@DanielCosme DanielCosme merged commit 4ca9fb0 into main Jun 3, 2024
9 checks passed
@DanielCosme DanielCosme deleted the dev/make-heartbeat-timeouts-configurable branch June 3, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants