Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping Python 3.7 usage and solving emoji issue #252

Merged
merged 5 commits into from
Feb 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:

strategy:
matrix:
python-version: ["3.7"]
python-version: ["3.8"]

steps:

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.7", "3.8", "3.9"]
python-version: ["3.8", "3.9"]
if: ${{ !contains(github.event.pull_request.labels.*.name, 'draft') }}

steps:
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
default_language_version:
python: python3.7
python: python3.8


repos:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ download-poetry:

.PHONY: install
install:
poetry env use python3.7
poetry env use python3.8
poetry lock -n
poetry install -n
ifneq ($(NO_PRE_COMMIT), 1)
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ Cannot find what you were looking for? Feel free to open an [issue]((https://git

### Supported Python Versions

- Main version supported : `3.7`
- Other supported versions : `3.8`
- Main version supported : `3.8`
- Other supported versions : `3.9`


We strongly advise you to do the remaining steps in a virtual environnement.
Expand Down
5 changes: 3 additions & 2 deletions nlpretext/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@
# along with this program; if not, write to the Free Software Foundation,
# Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

# type: ignore[attr-defined]
"""All the goto functions you need to handle NLP use-cases, integrated in NLPretext"""
# mypy: disable-error-code="attr-defined"
# mypy: disable-error-code="assignment"

"""All the goto functions you need to handle NLP use-cases, integrated in NLPretext"""

from nlpretext.preprocessor import Preprocessor

Expand Down
3 changes: 2 additions & 1 deletion nlpretext/_config/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,12 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License
# mypy: disable-error-code="attr-defined"

"""
Collection of regular expressions and other (small, generally useful) constants.
Credits to textacy for some of them: https://github.com/chartbeat-labs/textacy
"""

import re
import sys
import unicodedata
Expand Down
2 changes: 2 additions & 0 deletions nlpretext/_utils/file_loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
# You should have received a copy of the GNU Lesser General Public License
# along with this program; if not, write to the Free Software Foundation,
# Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
# mypy: disable-error-code="assignment"

from typing import List, Union

import chardet
Expand Down
4 changes: 2 additions & 2 deletions nlpretext/cli/__main__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# type: ignore[attr-defined]
# mypy: disable-error-code="attr-defined"

import typer
from nlpretext import __version__
Expand All @@ -14,7 +14,7 @@
console = Console()


def version_callback(value: bool):
def version_callback(value: bool) -> None:
"""Prints the version of the package."""
if value:
console.print(f"[yellow]nlpretext[/] version: [bold blue]{__version__}[/]")
Expand Down
1 change: 1 addition & 0 deletions nlpretext/textloader.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# mypy: disable-error-code="attr-defined"
try:
import dask.bag as db
import dask.dataframe as dd
Expand Down
2 changes: 2 additions & 0 deletions nlpretext/token/tokenizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
# You should have received a copy of the GNU Lesser General Public License
# along with this program; if not, write to the Free Software Foundation,
# Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
# mypy: disable-error-code="assignment"

from typing import Any, List, Optional, Union

import os
Expand Down
Loading