Fix x formatting token on Python 2.7 #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #781 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1695 1695
Branches 289 289
=========================================
Hits 1695 1695
Continue to review full report at Codecov.
|
systemcatch
approved these changes
May 2, 2020
There was a problem hiding this comment.
@jadchaar pulled your branch and tox for 2.7/3.7 runs fine. I think we're good to merge then cut a release.
| @@ -29,7 +29,7 @@ clean: | |||
| rm -rf dist build .egg .eggs arrow.egg-info | |||
| rm -f ./**/*.pyc .coverage | |||
|
|
|||
| publish: | |||
| publish: test | |||
systemcatch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
Fix bug with Python 2.7 and the new "x" token.