Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change zipOrAccumulate to not use delegated properties to prevent IAE #3533

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

kyay10
Copy link
Collaborator

@kyay10 kyay10 commented Nov 13, 2024

Workaround for KT-73089
As per the discussion on slack. I simply made zipOrAccumulate not use by and instead use a .value property I added. Oh and also I made the operator fun getValue an inline extension method as per the optimization requirements for getValue functions that don't use the KProperty they're given. I also sealed Value because it didn't need to be inheritable.

@kyay10 kyay10 requested a review from serras November 13, 2024 20:17
@StylianosGakis
Copy link
Contributor

For the ones interested in previous discussion here are some links.
Kotlinlang conversation link: https://kotlinlang.slack.com/archives/C5UPMM0A0/p1731449652340769
Public kotlinlang archive channel link: https://slack-chats.kotlinlang.org/t/23415572/tried-bumping-to-2-0-0-beta-1-and-i-am-getting-a-super-weird#8eb0739e-90ef-4b6f-96b3-aa9eda361e04

Copy link
Contributor

@serras serras merged commit b490817 into main Nov 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants