Make Schedule a fun interface
#3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS: This also updates Kotlin to 2.1.0-Beta2, since 2.0.21 was giving a very weird compiler error. |
|
It seems that this breaks in Native. The error is now reported in YouTrack |
kyay10
reviewed
Nov 4, 2024
arrow-libs/resilience/arrow-resilience/src/commonMain/kotlin/arrow/resilience/Schedule.kt
Show resolved
Hide resolved
Kover Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3325
Fixes #3499
It turns out that using a
value classcontaining a function inside is equivalent to having just afun interface. So I've reworkedSchedulein that form, which hopefully should remove the problems we have with inlining. @dave08 @postfixNotationThis change is breaking, but since in 2.0 we only promised source compatibility (and not binary compatibility), this should still be OK.