Deprecate Iterable#unzip in favor of stdlib method

[terminalnode]

From what I can tell the other unzip methods have no equivalent in the stdlib.

NonEmptyList is of course covered by the Iterable#unzip, but still has a use-case because of returning a pair of NonEmptyLists rather than a pair of regular Lists.

This is Iterable#unzip in kotlin 1.9.22:

public fun <T, R> Iterable<Pair<T, R>>.unzip(): Pair<List<T>, List<R>> {
    val expectedSize = collectionSizeOrDefault(10)
    val listT = ArrayList<T>(expectedSize)
    val listR = ArrayList<R>(expectedSize)
    for (pair in this) {
        listT.add(pair.first)
        listR.add(pair.second)
    }
    return listT to listR
}

[kyay10]

This should just delegate to stdlib unzip

[terminalnode]

In addition to the deprecation you mean? Changed this in e81b318, not sure if there's a better way to call the standard library method than using an import alias though (to avoid confusion with the other unzip methods in the file).

[kyay10]

Yes, that's exactly what I intended! I think an import alias is just the right approach here. I wonder how the ReplaceWith will function because of the name discrepancy though. kotlin.collections.* is a default import, and so perhaps we could just deprecate this with HIDDEN level. I'd rather wait though on another reviewer's opinion as to whether HIDDEN is the right approach here or not.

[kyay10]

NonEmptyList is of course covered by the Iterable#unzip, but still has a use-case because of returning a pair of NonEmptyLists rather than a pair of regular Lists.

Perhaps the implementation for NonEmptyList should use stdlib's unzip and then call toNonEmptyListOrNull()!!. You can do that in this PR if you want, but it's not necessary for now.

[terminalnode]

NonEmptyList is of course covered by the Iterable#unzip, but still has a use-case because of returning a pair of NonEmptyLists rather than a pair of regular Lists.

Perhaps the implementation for NonEmptyList should use stdlib's unzip and then call toNonEmptyListOrNull()!!. You can do that in this PR if you want, but it's not necessary for now.

Added this in 484e3df. I can't run all the tests locally for some reason (getting some random failures even with the main branch), but I think all the relevant tests are passing.

[kyay10]

The PR checks will take care of trying the tests, don't worry!

[nomisRev]

I can't run all the tests locally for some reason (getting some random failures even with the main branch)

Might be KMP setup, like @kyay10 said, not important since CI verifies everything but if you run into this again in the future KDoctor is a great tool to help you setup your KMP development environment.

[nomisRev]

LGTM. Thank you @terminalnode! 🙌