Make a common public parent for raise exception

[nomisRev]

No description provided.

[github-actions]

Kover Report

File	Coverage [95.45%]
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/raise/Fold.kt	98.11%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/raise/Trace.kt	50.00%
arrow-libs/core/arrow-core/src/jsMain/kotlin/arrow/core/raise/CancellationExceptionNoTrace.kt	100.00%
arrow-libs/core/arrow-core/src/jvmMain/kotlin/arrow/core/raise/CancellationExceptionNoTrace.kt	100.00%
arrow-libs/core/arrow-core/src/nativeMain/kotlin/arrow/core/raise/CancellationExceptionNoTrace.kt	100.00%

Total Project Coverage	53.96%

[kyay10]

What type of code is this PR intended to allow? merely distinguishing Raise errors from other cancellations, or is it something more? I ask because raised and raise are both internal, and I'm thinking that potentially exposing them could be useful for debugging such cases or logging them. Alternatively, we might want to add a better toString for the exception to include the raised and raise.

[nomisRev]

Yes, the only goal was merely distinguishing Raise errors from other cancellations as we've discussed in your CCE PR.

I ask because raised and raise are both internal, and I'm thinking that potentially exposing them could be useful for debugging such cases or logging them. Alternatively, we might want to add a better toString for the exception to include the raised and raise.

I didn't want to prematurely add it, since there are safer and better ways to access those values. Such as traced, recover, attempt if its get added, etc.

It'll be easy to expose it later on, but hard/impossible to remove.

[kyay10]

I like this change because it finally allows the usage intended by the try-catch tests.
Should we update the tests to reflect that? I think now they're catching general Throwable, so perhaps we can change it to RaiseCancellationException.

[nomisRev]

Yes, to both your comments @kyay10! Will update the PR momentarily 👍

[nomisRev]

@kyay10 I added your suggestions.

The message of the exception always includes:

internal const val RaiseCancellationExceptionCaptured: String =
  "kotlin.coroutines.cancellation.CancellationException should never get swallowed. Always re-throw it if captured." +
    "This swallows the exception of Arrow's Raise, and leads to unexpected behavior." +
    "When working with Arrow prefer Either.catch or arrow.core.raise.catch to automatically rethrow CancellationException."

[serras]

Nice!

[kyay10]

LGTM!