Separate 'arrow-eval' module #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kover Report
|
franciscodr
reviewed
Jan 16, 2024
Comment on lines
+27
to
+29
| * methods, which use an internal trampoline to avoid stack overflows. | ||
| * Computation done within .map and .flatMap is always done lazily, | ||
| * even when applied to a Now instance. |
There was a problem hiding this comment.
This text seems to be incomplete
There was a problem hiding this comment.
The file is just restored from the original version :/
franciscodr
approved these changes
Jan 16, 2024
nomisRev
pushed a commit
to arrow-kt/arrow-website
that referenced
this pull request
Jan 17, 2024
Now that we are [keeping `Eval`](arrow-kt/arrow#3332), it makes sense to bring it to the website.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spent some time trying to write a good guide for #3039, and have come to the conclusion that a full replacement for
Evalis difficult to achieve. So I've taken one of the suggestions there: move it into its own separatearrow-evalmodule. I think we can do like we've done witharrow-resilienceandarrow-functions, and nudge people to move into the new module if we bring it in 1.2.2, and then remove it fromarrow-corein 2.0.The code is ready to be merged too in
arrow-2, with just a few adjustments needed in the Gradle build file.