Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate EagerEffectSpec to kotlin-test #3233

Merged
merged 2 commits into from
Oct 26, 2023
Merged

refactor: migrate EagerEffectSpec to kotlin-test #3233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
054a0dd
refactor: migrate EagerEffectSpec to kotlin-test
milgner Oct 21, 2023
f9f35e9
Merge branch 'arrow-2' into refactor-kotest/eagereffectspec
serras Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 31 additions & 29 deletions arrow-libs/core/arrow-core/src/commonTest/kotlin/arrow/core/raise/EagerEffectSpec.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,13 @@ import io.kotest.property.arbitrary.long
import io.kotest.property.arbitrary.orNull
import io.kotest.property.arbitrary.string
import io.kotest.property.checkAll
import kotlin.test.Test
import kotlinx.coroutines.CompletableDeferred
import kotlinx.coroutines.test.runTest

@Suppress("UNREACHABLE_CODE", "UNUSED_EXPRESSION")
class EagerEffectSpec : StringSpec({
"try/catch - can recover from raise" {
class EagerEffectSpec {
@Test fun tryCatchCanRecoverFromRaise() = runTest {
checkAll(Arb.int(), Arb.string()) { i, s ->
eagerEffect {
try {
Expand All @@ -34,7 +36,7 @@ class EagerEffectSpec : StringSpec({
}
}

"try/catch - finally works" {
@Test fun tryCatchFinallyWorks() = runTest {
checkAll(Arb.string(), Arb.int()) { s, i ->
val promise = CompletableDeferred<Int>()
eagerEffect {
Expand All @@ -49,7 +51,7 @@ class EagerEffectSpec : StringSpec({
}
}

"try/catch - First raise is ignored and second is returned" {
@Test fun tryCatchFirstRaiseIsIgnoredAndSecondIsReturned() = runTest {
checkAll(Arb.int(), Arb.string(), Arb.string()) { i, s, s2 ->
eagerEffect<String, Int> {
try {
Expand All @@ -62,7 +64,7 @@ class EagerEffectSpec : StringSpec({
}
}

"recover - catch" {
@Test fun recoverCatch() = runTest {
checkAll(Arb.int(), Arb.long()) { i, l ->
eagerEffect<String, Int> {
eagerEffect<Long, Int> {
Expand All @@ -75,7 +77,7 @@ class EagerEffectSpec : StringSpec({
}
}

"recover - no catch" {
@Test fun recoverNoCatch() = runTest {
checkAll(Arb.int(), Arb.long()) { i, l ->
eagerEffect<String, Int> {
eagerEffect<Long, Int> {
Expand All @@ -88,7 +90,7 @@ class EagerEffectSpec : StringSpec({
}
}

"recover - raise from catch" {
@Test fun recoverRaiseFromCatch() = runTest {
checkAll(Arb.long(), Arb.string()) { l, error ->
eagerEffect {
eagerEffect<Long, Int> {
Expand All @@ -101,26 +103,26 @@ class EagerEffectSpec : StringSpec({
}
}

"success" {
@Test fun success() = runTest {
eagerEffect<Nothing, Int> { 1 }
.fold({ unreachable() }, ::identity) shouldBe 1
}

"short-circuit" {
@Test fun shortCircuit() = runTest {
eagerEffect {
raise("hello")
}.fold(::identity) { unreachable() } shouldBe "hello"
}

"Rethrows exceptions" {
@Test fun rethrowsExceptions() = runTest {
val e = RuntimeException("test")
Either.catch {
eagerEffect<Nothing, Nothing> { throw e }
.fold({ unreachable() }, { unreachable() })
} shouldBe Either.Left(e)
}

"ensure null in eager either computation" {
@Test fun ensureNullInEagerEitherComputation() = runTest {
checkAll(Arb.boolean(), Arb.int(), Arb.string()) { predicate, success, raise ->
either {
ensure(predicate) { raise }
Expand All @@ -129,7 +131,7 @@ class EagerEffectSpec : StringSpec({
}
}

"ensureNotNull in eager either computation" {
@Test fun ensureNotNullInEagerEitherComputation() = runTest {
fun square(i: Int): Int = i * i

checkAll(Arb.int().orNull(), Arb.string()) { i: Int?, raise: String ->
Expand All @@ -142,7 +144,7 @@ class EagerEffectSpec : StringSpec({
}
}

"recover - happy path" {
@Test fun recoverHappyPath() = runTest {
checkAll(Arb.string()) { str ->
eagerEffect<Int, String> {
str
Expand All @@ -151,7 +153,7 @@ class EagerEffectSpec : StringSpec({
}
}

"recover - error path and recover" {
@Test fun recoverErrorPathAndRecover() = runTest {
checkAll(Arb.int(), Arb.string()) { int, fallback ->
eagerEffect<Int, String> {
raise(int)
Expand All @@ -161,7 +163,7 @@ class EagerEffectSpec : StringSpec({
}
}

"recover - error path and re-raise" {
@Test fun recoverErrorPathAndReRaise() = runTest {
checkAll(Arb.int(), Arb.string()) { int, fallback ->
eagerEffect<Int, Unit> {
raise(int)
Expand All @@ -171,7 +173,7 @@ class EagerEffectSpec : StringSpec({
}
}

"recover - error path and throw" {
@Test fun recoverErrorPathAndThrow() = runTest {
checkAll(Arb.int(), Arb.string()) { int, msg ->
shouldThrow<RuntimeException> {
eagerEffect<Int, String> {
Expand All @@ -183,7 +185,7 @@ class EagerEffectSpec : StringSpec({
}
}

"catch - happy path" {
@Test fun catchHappyPath() = runTest {
checkAll(Arb.string()) { str ->
eagerEffect<Int, String> {
str
Expand All @@ -192,7 +194,7 @@ class EagerEffectSpec : StringSpec({
}
}

"catch - error path and recover" {
@Test fun catchErrorPathAndRecover() = runTest {
checkAll(Arb.string(), Arb.string()) { msg, fallback ->
eagerEffect<Int, String> {
throw RuntimeException(msg)
Expand All @@ -201,7 +203,7 @@ class EagerEffectSpec : StringSpec({
}
}

"catch - error path and re-raise" {
@Test fun catchErrorPathAndReRaise() = runTest {
checkAll(Arb.string(), Arb.int()) { msg, fallback ->
eagerEffect<Int, Unit> {
throw RuntimeException(msg)
Expand All @@ -210,7 +212,7 @@ class EagerEffectSpec : StringSpec({
}
}

"catch - error path and throw" {
@Test fun catchErrorPathAndThrow() = runTest {
checkAll(Arb.string(), Arb.string()) { msg, msg2 ->
shouldThrow<RuntimeException> {
eagerEffect<Int, String> {
Expand All @@ -221,21 +223,21 @@ class EagerEffectSpec : StringSpec({
}
}

"catch - reified exception and recover" {
@Test fun catchReifiedExceptionAndRecover() = runTest {
eagerEffect<Nothing, Int> {
throw ArithmeticException()
}.catch { _: ArithmeticException -> 1 }
.fold({ unreachable() }, ::identity) shouldBe 1
}

"catch - reified exception and raise" {
@Test fun catchReifiedExceptionAndRaise() = runTest {
eagerEffect<String, Int> {
throw ArithmeticException("Boom!")
}.catch { e: ArithmeticException -> raise(e.message.shouldNotBeNull()) }
.fold(::identity) { unreachable() } shouldBe "Boom!"
}

"catch - reified exception and no match" {
@Test fun catchReifiedExceptionAndNoMatch() = runTest {
shouldThrow<RuntimeException> {
eagerEffect<Nothing, Int> {
throw RuntimeException("Boom!")
Expand All @@ -244,7 +246,7 @@ class EagerEffectSpec : StringSpec({
}.message shouldBe "Boom!"
}

"shift leaked results in RaiseLeakException" {
@Test fun shiftLeakedResultsInRaiseLeakException() = runTest {
eagerEffect {
suspend { raise("failure") }
}.fold(
Expand All @@ -254,7 +256,7 @@ class EagerEffectSpec : StringSpec({
{ unreachable() }) { f -> f() }
}

"shift leaked results in RaiseLeakException with exception" {
@Test fun shiftLeakedResultsInRaiseLeakExceptionWithException() = runTest {
shouldThrow<IllegalStateException> {
val leak = CompletableDeferred<suspend () -> Unit>()
eagerEffect {
Expand All @@ -270,7 +272,7 @@ class EagerEffectSpec : StringSpec({
}.message shouldStartWith "raise or bind was called outside of its DSL scope"
}

"shift leaked results in RaiseLeakException after raise" {
@Test fun shiftLeakedResultsInRaiseLeakExceptionAfterRaise() = runTest {
shouldThrow<IllegalStateException> {
val leak = CompletableDeferred<suspend () -> Unit>()
eagerEffect {
Expand All @@ -285,7 +287,7 @@ class EagerEffectSpec : StringSpec({
}.message shouldStartWith "raise or bind was called outside of its DSL scope"
}

"mapError - raise and transform error" {
@Test fun mapErrorRaiseAndTransformError() = runTest {
checkAll(Arb.long(), Arb.string()) { l, s ->
(eagerEffect<Long, Int> {
raise(l)
Expand All @@ -296,10 +298,10 @@ class EagerEffectSpec : StringSpec({
}
}

"mapError - success" {
@Test fun mapErrorSuccess() = runTest {
checkAll(Arb.int()) { i ->
(eagerEffect<Long, Int> { i } mapError { unreachable() })
.get() shouldBe i
}
}
})
}