Remove Monoid and Semigroup combine from replacements

[gutiory]

This PR replace any method that belongs to deprecated Monoid or Semigroup that are in the deprecation replacements.

The last commit just deprecates the foldMap method in Fold interface. I'd need extra 👀 on this, because a bunch of other interfaces implement this interface. Basically, I've done the following:

• Deprecated the foldMap implementation that has a Monoid parameter
• Remove the foldMap implementation that does not have the Monoid, but that creates one and used the deprecated foldMap. This makes this method abstract.
• Every interface that uses Fold implements now the abstract foldMap.

[serras]

This PR replace any method that belongs to deprecated Monoid or Semigroup that are in the deprecation replacements.

The last commit just deprecates the foldMap method in Fold interface. I'd need extra 👀 on this, because a bunch of other interfaces implement this interface. Basically, I've done the following:

* Deprecated the `foldMap` implementation that has a `Monoid` parameter

* Remove the `foldMap` implementation that does not have the `Monoid`, but that creates one and used the deprecated `foldMap`. This makes this method abstract.

* Every interface that uses `Fold` implements now the abstract `foldMap`.

Sorry if this was not clear from the original PR, but we decided against taking that route. The reason is that we break binary compatibility. The breaking change of actually making foldMap with combine and empty the "main" version is for 2.0.

[serras]

I am a bit confused by these replacements. This won't result in correct code, right?

[gutiory]

Yes, it won't work. I'm writing an entry in the arrow web migration guide just to explain this. It's the only way to get rid of the Monoid.empty deprecated method.

[github-actions]

Kover Report

File	Coverage [65.03%]
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Either.kt	57.34%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Ior.kt	59.22%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Iterable.kt	85.55%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/NonEmptyList.kt	74.19%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Option.kt	53.02%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Sequence.kt	63.26%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Validated.kt	50.00%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/map.kt	90.64%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/typeclasses/Semigroup.kt	12.50%

Total Project Coverage	44.31%

[serras]

Looking forward to seeing how the migration guide looks like :)

[franciscodr]

Regarding the Monoid empty value, I see we name it differently in some ReplaceWith expressions, like empty, initial, or initialValue. We could choose a unique identifier and use it in all the examples for consistency.

[gutiory]

Regarding the Monoid empty value, I see we name it differently in some ReplaceWith expressions, like empty, initial, or initialValue. We could choose a unique identifier and use it in all the examples for consistency.

Absolutely, @franciscodr . I've mixed some names from Monoid.empty() and others from the fold parameter.
What about to rename all with the name of the fold parameter we're suggesting to be replaced with?

[franciscodr]

Regarding the Monoid empty value, I see we name it differently in some ReplaceWith expressions, like empty, initial, or initialValue. We could choose a unique identifier and use it in all the examples for consistency.

Absolutely, @franciscodr . I've mixed some names from Monoid.empty() and others from the fold parameter. What about to rename all with the name of the fold parameter we're suggesting to be replaced with?

Yeah, makes sense to me

[franciscodr]

Thanks, @gutiory!