Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DSL markers to all bind funs in Raise #2944

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Add DSL markers to all bind funs in Raise #2944

merged 1 commit into from
Feb 23, 2023

Conversation

Zordid
Copy link
Contributor

@Zordid Zordid commented Feb 23, 2023

Found that all bind() funs in Raise.kt where missing the corresponding DslMarker annotation. They did not get colored in IntelliJ and that is extremely visible when combining resource scopes and effect scopes.

nomisRev
nomisRev approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Zordid 🙌 And your interests, and contributions to Arrow 😍

@nomisRev nomisRev requested a review from a team February 23, 2023 09:36
@nomisRev nomisRev merged commit f4f13ce into arrow-kt:main Feb 23, 2023
@Zordid Zordid deleted the add_raisedslmarker_to_bind branch February 23, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomisRev nomisRev nomisRev approved these changes

@serras serras serras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zordid @serras @nomisRev