Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More contract annotations for Either, Ior, Nullable, and Option #2915

Merged
merged 2 commits into from
Feb 4, 2023
Merged

More contract annotations for Either, Ior, Nullable, and Option #2915

merged 2 commits into from
Feb 4, 2023

Conversation

serras
Copy link
Member

@serras serras commented Feb 3, 2023

More progress towards #2806

@serras serras requested review from nomisRev and a team February 3, 2023 15:50
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023 •
edited
Loading

Kover Report

File Coverage [53.24%]
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Either.kt 48.39%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Ior.kt 59.28%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Nullable.kt 100.00%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Option.kt 44.74%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Result.kt 53.85%
Total Project Coverage 42.65%

nomisRev
nomisRev approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!! Thank you @serras 😍

@nomisRev nomisRev requested a review from a team February 3, 2023 21:06
@nomisRev nomisRev merged commit f6c49fc into main Feb 4, 2023
@nomisRev nomisRev deleted the as-more-contracts branch February 4, 2023 21:09
@serras serras mentioned this pull request Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomisRev nomisRev nomisRev approved these changes

@franciscodr franciscodr franciscodr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serras @franciscodr @nomisRev