Remove Tuple10 to Tuple22, Const, Eval, computation blocks, and arrow-continuations #2784

serras · 2022-08-02T15:15:19Z

No description provided.

nomisRev · 2022-08-03T06:27:04Z

🔥

raulraja

thanks @serras !

i-walker

Thanks @serras ! 🙌🏾

serras · 2022-12-05T20:34:06Z

The JS and Native builds are failing because they expect arrow-continuations, but this is in fact one of the things removed by this PR.

e: Could not find "io.arrow-kt:arrow-continuations" in [/Users/serras/arrow/arrow, /Users/serras/.konan/klib, /Users/serras/.konan/kotlin-native-prebuilt-macos-x86_64-1.7.22/klib/common, /Users/serras/.konan/kotlin-native-prebuilt-macos-x86_64-1.7.22/klib/platform/ios_simulator_arm64]

I expected the problem to go away by excluding arrow-core from the dependencies of kotest-extensions-arrow, thinking that it would also exclude anything based on it. But I guess my assumption was wrong...

nomisRev · 2022-12-05T21:31:20Z

I am unsure we can rely on the kites extension for Arrow in the 2.x.x since they're build using 1.x.x, and both versions are not compatible.. 🤔

serras · 2022-12-05T22:22:11Z

I guess I’ll have to revert the removal of the test modules, then.

nomisRev · 2022-12-06T07:37:04Z

@serras if you want I can decouple them in 1.x.x, and we can merge that to 2.x.x

serras · 2022-12-06T07:38:51Z

Wouldn’t we have the same problem? We cannot depend on the test module until there’s a 2.x-compatible version, right?

serras · 2022-12-06T07:40:15Z

Another option would be to stop depending on things like ArrowFxSpec, but keep the few utilities and generators in commonTest for each project.

nomisRev · 2022-12-06T08:30:43Z

Wouldn’t we have the same problem? We cannot depend on the test module until there’s a 2.x-compatible version, right?

I mean stop relying on the test-module entirely. So decouple the test-module from Arrow Core, to avoid the circular dependency.

Another option would be to stop depending on things like ArrowFxSpec, but keep the few utilities and generators in commonTest for each project.

So doing this yes. ArrowFxSpec was originally brought to live mostly to introduce iterations properties, but this can also be globally overwritten through AbstractKotestProject. Limiting the_depth_ of lists should probably become explicitly where needed only.

github-actions · 2022-12-29T13:34:08Z

Kover Report

File	Coverage [34.90%]
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Option.kt	39.90%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/TupleN.kt	0.00%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/typeclasses/Monoid.kt	74.19%
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/typeclasses/Semigroup.kt	32.50%
arrow-libs/core/arrow-core/src/jsMain/kotlin/arrow/core/NonFatal.kt	100.00%
arrow-libs/core/arrow-core/src/jvmMain/kotlin/arrow/core/NonFatal.kt	100.00%
arrow-libs/core/arrow-core/src/nativeMain/kotlin/arrow/core/NonFatal.kt	100.00%
arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/Schedule.kt	52.89%
arrow-libs/optics/arrow-optics/src/commonMain/kotlin/arrow/optics/Every.kt	2.86%
arrow-libs/optics/arrow-optics/src/commonMain/kotlin/arrow/optics/Traversal.kt	4.42%

Total Project Coverage	41.19%

serras · 2022-12-29T15:13:23Z

@nomisRev @i-walker @raulraja this is now really ready to be merged, I've managed to remove the dependency on the tests on main, and take the whole thing up to here

nomisRev

Looking great overall. Wondering why the iteration count was dropped from 1000 to 10 in Arrow Optics.

arrow-libs/core/arrow-core/src/commonTest/kotlin/arrow/core/EitherZipTest.kt

gradle.properties

nomisRev · 2023-01-12T16:05:53Z

Thanks @serras 🙌 That was a big chunk.

* The beginning of Arrow 2.0 * Resource Arrow 2.0 (#2786) * Flatten Resource ADT, maintain API * [Arrow 2.0] Effect without suspending shift (#2797) * Shift without suspend, inline all the rest * Add new error handlers signatures * Make ShiftCancellationException private * Rename Shift to Raise according to Slack Poll, and add some initial docs (#2827) * Remove all references to shift from new Arrow 2.0 code (#2834) * Remove all references to shift from new code * Update API files * Fixes merge conflict between main and arrow-2 (#2835) * Add Resource.allocated() to decompose Resource into it's allocate and… (#2820) * [2743] Migrate internal use of CircuitBreaker double to duration (#2748) * Fix typo (#2824) * Make the server disconnect test more general (#2822) * Update NonEmptyList.fromList deprecation to suggest `toOption()` instead (#2832) * Improve Either.getOrHandle() docs (#2833) * Improve allocated, and fix knit examples Co-authored-by: Jeff Martin <[email protected]> Co-authored-by: Martin Moore <[email protected]> Co-authored-by: valery1707 <[email protected]> Co-authored-by: Lukasz Kalnik <[email protected]> Co-authored-by: stylianosgakis <[email protected]> * Add Atomic module, and StateShift (#2817) * Two small deprecations * Add Atomic module, and StateShift. Implement ior through StateShift * Fix build * Fix atomic knit * Fix knit attempt #2 * Update API files * Remove references to shift * Change return type of raise to Nothing (#2839) * Change return type of raise to Nothing Implements #2805 * Update public api with ./gradlew apiDump * Suppress warnings for unreachable calls to fail in tests The test is verifying that no code will be executed after a call to raise, so it's actually testing the very behaviour that the compiler is warning us about. Co-authored-by: Alejandro Serrano <[email protected]> * Update API files * Increase timeout * Fix compiler bug with nested inline + while + return * Clean up ExitCase.fromError * Update API files@ * Feature/remove validated (#2795) Co-authored-by: Simon Vergauwen <[email protected]> Co-authored-by: Alejandro Serrano <[email protected]> * Remove CancellationExceptionNoTrace.kt after merge, and run apiDump * Add missing runnerJUnit5 for arrow-atomic JVM * Publish Arrow 2.0.0-SNAPSHOT (#2871) Co-authored-by: Javier Segovia Córdoba <[email protected]> * Simplify optics to Traversal/Optional/Lens/Prism (#2873) * 'mapOrAccumulate' for Raise (#2872) Co-authored-by: Simon Vergauwen <[email protected]> * Fix problems with Atomic * Smaller timeouts * Remove Tuple10 to Tuple22, Const, Eval, computation blocks, and arrow-continuations (#2784) * Revert typo * Fix build * Fix ParMapJvmTest * Implement NonEmptyList using value class (#2911) * Fix merge w.r.t. Saga * apiDump * Test other return expression * change unalign signature (#2972) see discussion in #2960 (comment) #2960 (comment) --------- Co-authored-by: Alejandro Serrano <[email protected]> * Update after merge main * Fix :arrow-optics-ksp-plugin:compileKotlin * Fix Every instances * Move functions to arrow functions (#3014) * Bring back `Iso` (#3013) * Bring back Iso * API Dump --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update BOM (#3019) * Fix andThen duplication (#3020) * Fix Knit * Fix weird problem with value classes * Update API docs * Update publish workflow Following the instructions in #3090 (comment) * No closing repo on snapshot * knit * Fix optics tests * Fix after merge * Refactor ParMapTest from Kotest Plugin to Kotlin-test runtime #3191 (#3221) Co-authored-by: Simon Vergauwen <[email protected]> Co-authored-by: Alejandro Serrano <[email protected]> * Refactor: Use Kotlin-test runtime for arrow-fx-stm tests (#3224) Co-authored-by: Alejandro Serrano <[email protected]> * Update all Gradle files to mention kotlin.test * Refactor ParZip2Test from Kotest Plugin to Kotlin-test runtime #3192 (#3222) Co-authored-by: Alejandro Serrano <[email protected]> * Refactor ParZip3Test from Kotest Plugin to Kotlin-test runtime #3193 (#3223) Co-authored-by: Alejandro Serrano <[email protected]> * Refactor GuaranteeCaseTest to use kotlin test (#3226) Closes #3190 * refactor: migrate NotEmptySetTest to kotlin-test (#3230) Co-authored-by: Alejandro Serrano <[email protected]> * refactor: migrate EagerEffectSpec to kotlin-test (#3233) Co-authored-by: Alejandro Serrano <[email protected]> * Refactor NullableSpec from Kotest Plugin to Kotlin-test runtime (#3236) #3153 Co-authored-by: Alejandro Serrano <[email protected]> * Refactor BracketCaseTest to use kotlin test (#3237) Closes #3186 Co-authored-by: Alejandro Serrano <[email protected]> * Move arrow-functions tests to kotlin.test (#3243) * Inline `AtomicBoolean` (#3240) * Inline AtomicBoolean * Update API files --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * refactor: migrate MappersSpec to kotlin-test (#3248) * Refactor ResourceTestJvm from Kotest Plugin to Kotlin-test runtime (#3244) Closes #3213 * refactor: migrate FlowJvmTest to Kotlin-test (#3228) * Refactor ParZip9JvmTest from Kotest Plugin to Kotlin-test runtime (#3245) Closes #3211 * Refactor ParZip8JvmTest from Kotest Plugin to Kotlin-test runtime (#3246) Closes #3210 * refactor: migrate NumberInstancesTest to kotlin-test (#3232) * refactor: OptionTest to kotlin-test runtime (#3229) * Revert "Inline `AtomicBoolean` (#3240)" (#3279) This reverts commit a6f1e73. * Refactor ParZip6JvmTest from Kotest Plugin to Kotlin-test runtime (#3255) Closes #3208 * Refactor ParZip5JvmTest from Kotest Plugin to Kotlin-test runtime (#3256) Closes #3207 * Refactor ParZip3JvmTest from Kotest Plugin to Kotlin-test runtime (#3258) Closes #3205 * Refactor ParZip2JvmTest from Kotest Plugin to Kotlin-test runtime (#3259) Closes #3204 * Refactor ParMapJvmTest from Kotest Plugin to Kotlin-test runtime (#3260) Closes #3203 * Refactor ParZip4JvmTest from Kotest Plugin to Kotlin-test runtime (#3257) Closes #3206 * refactor: migrate RaiseAccumulateSpec to kotlin-test (#3250) * Refactor ParZip7JvmTest from Kotest Plugin to Kotlin-test runtime (#3247) Closes #3209 Co-authored-by: Alejandro Serrano <[email protected]> * Update ComparisonKtTest.kt (#3274) Co-authored-by: Simon Vergauwen <[email protected]> * Update OptionSpec.kt (#3271) Co-authored-by: Simon Vergauwen <[email protected]> * Update TraceJvmSpec.kt (#3276) * Update TraceJvmSpec.kt * Update TraceJvmSpec.kt --------- Co-authored-by: Simon Vergauwen <[email protected]> * Update ParZip9Test.kt (#3265) * Update ParZip9Test.kt * Update ParZip9Test.kt * Update ParZip8Test.kt (#3266) * Update ParZip7Test.kt (#3267) * Update ParZip6Test.kt (#3268) * Update ParZip5Test.kt (#3269) * Update ParZip4Test.kt (#3270) * Refactor CountDownLatchSpec and CyclicBarrierSpec to use kotlin test (#3227) * Refactor CountDownLatchSpec to use kotlin test Closes #3187 * Refactor CyclicBarrierSpec to use kotlin test Closes #3188 --------- Co-authored-by: Alejandro Serrano <[email protected]> * Refactor NonEmptyListTest to kotlin-test (#3231) * Add kotlin test dependency * Refactor NonEmptyList Test to use kotlin test --------- Co-authored-by: Alejandro Serrano <[email protected]> * refactor: migrate EffectSpec to kotlin-test (#3234) * Refactor FlowTest to use kotlin test (#3238) Closes #3189 Co-authored-by: Alejandro Serrano <[email protected]> * refactor: migrate IorSpec to kotlin-test (#3249) Co-authored-by: Simon Vergauwen <[email protected]> * refactor: migrate ResultSpec to kotlin-test (#3251) Co-authored-by: Simon Vergauwen <[email protected]> * refactor: migrate StructuredConcurrencySpec to kotlin-test (#3252) * refactor: migrate TraceSpec to kotlin-test (#3253) * refactor: migrate GeneratorsTest to kotlin-test (#3254) * Refactor RaceNJvmTest from Kotest Plugin to Kotlin-test runtime (#3261) Closes #3212 Co-authored-by: Alejandro Serrano <[email protected]> * Update ArrowResponseEAdapterTest.kt (#3264) * Update ArrowResponseEAdapterTest.kt * Update ArrowResponseEAdapterTest.kt --------- Co-authored-by: Simon Vergauwen <[email protected]> Co-authored-by: Alejandro Serrano <[email protected]> * Update CollectionsSyntaxTests.kt (#3273) * Update CollectionsSyntaxTests.kt * Update CollectionsSyntaxTests.kt --------- Co-authored-by: Simon Vergauwen <[email protected]> Co-authored-by: Alejandro Serrano <[email protected]> * Update NonFatalJvmTest.kt (#3277) * Update ArrowEitherCallAdapterTest.kt (#3278) * Update ArrowEitherCallAdapterTest.kt * Update ArrowEitherCallAdapterTest.kt * Move tests from `serialization` and `functions` completely to `kotlin.test` (#3289) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix problems with tests * Remove a bunch of warnings in `arrow-2` (#3282) Co-authored-by: serras <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Finish transition to `kotlin.test` of `retrofit` and `fx-coroutines` (#3291) * Fix problems with concurrency in tests, take 8 * Port rest of `arrow-core` to `kotlin.test` (#3292) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Implement `fixedRate` using monotonic time source (#3294) Co-authored-by: serras <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Port `optics` tests to `kotlin.test` (#3295) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Add or fix contracts in Raise (#3293) * Add or fix contracts in Raise * Make contracts less strict * Get back contract on Either * ignoreErrors should also be AT_MOST_ONCE --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Alternate `SingletonRaise` (#3328) Co-authored-by: Youssef Shoaib <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: serras <[email protected]> * Remove (unused) tests for high-arity module * Fix tests + Knit * Fix merge NullableSpec * Regression in Arb.list? * Fix test for nonEmptyList * Develocity warning * Fix merge problem with optics-ksp-plugin * Fix timeout in test --------- Co-authored-by: Simon Vergauwen <[email protected]> Co-authored-by: Sam Cooper <[email protected]> Co-authored-by: Marc Moreno Ferrer <[email protected]> Co-authored-by: Javier Segovia Córdoba <[email protected]> Co-authored-by: Alphonse Bendt <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andreas Storesund Madsen <[email protected]> Co-authored-by: molikuner <[email protected]> Co-authored-by: Jonathan Lagneaux <[email protected]> Co-authored-by: Marcus Ilgner <[email protected]> Co-authored-by: Chris Black <[email protected]> Co-authored-by: Tejas Mate <[email protected]> Co-authored-by: HyunWoo Lee (Nunu Lee) <[email protected]> Co-authored-by: serras <[email protected]> Co-authored-by: Youssef Shoaib <[email protected]>

Remove Tuple10 to Tuple22, Const, and Eval

ee22816

serras requested a review from a team August 2, 2022 15:15

serras self-assigned this Aug 2, 2022

serras mentioned this pull request Aug 2, 2022

Arrow 2.0 #2778

Merged

20 tasks

nomisRev added the 2.0.0 Tickets / PRs belonging to Arrow 2.0 label Aug 3, 2022

Remove computation blocks and test modules

6204412

serras changed the title ~~Remove Tuple10 to Tuple22, Const, and Eval~~ Remove Tuple10 to Tuple22, Const, Eval, computation blocks, and test modules Aug 3, 2022

Update API files

f15a57a

serras marked this pull request as draft August 3, 2022 10:58

serras added 7 commits August 3, 2022 14:59

Fix tests for arrow-core and arrow-core-retrofit

f1b84b1

Fix test for arrow-optics-reflect

7aed62b

Work on the optics tests

d6ce9c1

Remove thing added by IntelliJ

06201c5

Move kotest to plugins block in Gradle

5778c5c

Fix optics tests

6114a72

Do not use hardcoded version for kotest-arrow libs

82e36cb

serras marked this pull request as ready for review August 3, 2022 17:34

serras marked this pull request as draft August 3, 2022 17:34

raulraja approved these changes Aug 3, 2022

View reviewed changes

serras mentioned this pull request Aug 9, 2022

Feature/remove validated #2795

Merged

Merge branch 'arrow-2' into removed-in-arrow-2

80040cf

i-walker approved these changes Sep 3, 2022

View reviewed changes

Merge branch 'arrow-2' into removed-in-arrow-2

7d34bdd

serras marked this pull request as ready for review September 14, 2022 09:05

serras added 2 commits December 5, 2022 15:38

Add a few more tests

cc1733b

Merge branch 'arrow-2' into removed-in-arrow-2

669aece

serras requested review from raulraja, i-walker and nomisRev December 5, 2022 20:27

raulraja approved these changes Dec 5, 2022

View reviewed changes

Merge branch 'arrow-2' into removed-in-arrow-2

fe2ebeb

serras added 2 commits December 29, 2022 15:10

Merge branch 'arrow-2' into removed-in-arrow-2

df46601

Minimize changes w.r.t. arrow-2

abd2467

serras changed the title ~~Remove Tuple10 to Tuple22, Const, Eval, computation blocks, and test modules~~ Remove Tuple10 to Tuple22, Const, Eval, computation blocks, and arrow-continuations Dec 29, 2022

nomisRev reviewed Jan 2, 2023

View reviewed changes

arrow-libs/core/arrow-core/src/commonTest/kotlin/arrow/core/EitherZipTest.kt Outdated Show resolved Hide resolved

gradle.properties Outdated Show resolved Hide resolved

Apply suggestions

88e664e

nomisRev approved these changes Jan 8, 2023

View reviewed changes

serras added 2 commits January 9, 2023 10:55

Merge branch 'arrow-2' into removed-in-arrow-2

03e51d2

Merge branch 'arrow-2' into removed-in-arrow-2

7231973

serras merged commit 39e326f into arrow-2 Jan 12, 2023

serras deleted the removed-in-arrow-2 branch January 12, 2023 13:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Tuple10 to Tuple22, Const, Eval, computation blocks, and arrow-continuations #2784

Remove Tuple10 to Tuple22, Const, Eval, computation blocks, and arrow-continuations #2784

serras commented Aug 2, 2022

nomisRev commented Aug 3, 2022

raulraja left a comment

i-walker left a comment

serras commented Dec 5, 2022

nomisRev commented Dec 5, 2022

serras commented Dec 5, 2022

nomisRev commented Dec 6, 2022

serras commented Dec 6, 2022

serras commented Dec 6, 2022

nomisRev commented Dec 6, 2022

github-actions bot commented Dec 29, 2022 •

edited

Loading

serras commented Dec 29, 2022

nomisRev left a comment

nomisRev commented Jan 12, 2023

Remove Tuple10 to Tuple22, Const, Eval, computation blocks, and arrow-continuations #2784

Remove Tuple10 to Tuple22, Const, Eval, computation blocks, and arrow-continuations #2784

Conversation

serras commented Aug 2, 2022

nomisRev commented Aug 3, 2022

raulraja left a comment

Choose a reason for hiding this comment

i-walker left a comment

Choose a reason for hiding this comment

serras commented Dec 5, 2022

nomisRev commented Dec 5, 2022

serras commented Dec 5, 2022

nomisRev commented Dec 6, 2022

serras commented Dec 6, 2022

serras commented Dec 6, 2022

nomisRev commented Dec 6, 2022

github-actions bot commented Dec 29, 2022 • edited Loading

Kover Report

serras commented Dec 29, 2022

nomisRev left a comment

Choose a reason for hiding this comment

nomisRev commented Jan 12, 2023

github-actions bot commented Dec 29, 2022 •

edited

Loading