add merge to validated

[agusotto96]

Adds a merge function to Validated, like the one found in Either

[agusotto96]

Hello Arrow team! I was playing around with ValidatedNel and found myself using .fold({ it }, { it }) to get a result. I thought maybe there was a shortcut for this and found the merge function in Either. It occurred to me that maybe it would be useful to add the same function for Validated.
Please let me know if this PR is good.

[nomisRev]

Hey @agusotto96,

Thanks for this PR!
We're being quite conservative with the API, but I think this operator makes a lot of sense for Validated!

[agusotto96]

Hi @nomisRev! Thanks a lot for answering, glad to help in any way, I'm really enjoying this library and all the resources provided by JetBrains and 47 Degrees.
By the way, I see that one of the checks failed, is this normal? Also, I have a few other small operators that I find interesting, should I keep adding them in PRs or should I open an issue?

[i-walker]

To keep consistency we may want to add this as an extension function, as in Either

arrow/arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Either.kt

Line 1383 in c28e7da

public inline fun <A> Either<A, A>.merge(): A =

[nomisRev]

@i-walker, you're correct.
It needs to be placed outside of Validated. I didn't catch that on the diff with the indentation 😱

This way it will not be conveniently accessible.

[nomisRev]

@agusotto96 I think CI failed with a false negative due to CI crashing.

org.gradle.launcher.daemon.client.DaemonDisappearedException: Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)

Also, I have a few other small operators that I find interesting, should I keep adding them in PRs or should I open an issue?

Opening an issue would be great, that way you prevent wasting efforts in case it doesn't make it in. There is also #arrow-contributors on KotlinLang Slack if you want to discuss some ideas be sure to check it out.

[agusotto96]

Perfect, will check those out! I moved the function outside of Validated, hope its ok this time 😅

[i-walker]

Thanks @agusotto96 👍🏾

[nomisRev]

Thank you for the contribution @agusotto96! And congrats on your first contribution to Arrow 🥳

[agusotto96]

Thanks! @i-walker @nomisRev