Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Continuations and programs to overview section in arrow core #2723

Merged
merged 7 commits into from
May 25, 2022
Merged

add Continuations and programs to overview section in arrow core #2723

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b44e5cf
add continuations and programs to overview
i-walker May 17, 2022
51cafbb
Merge branch 'main' into is-effect-overview
i-walker May 17, 2022
2cb8c4a
move effect section to quickstart div
i-walker May 17, 2022
5858b35
Merge branch 'main' into is-effect-overview
i-walker May 17, 2022
e071acb
Update arrow-site/docs/docs/core/README.md
i-walker May 21, 2022
312d1ec
Merge branch 'main' into is-effect-overview
i-walker May 23, 2022
5440ec1
Merge branch 'main' into is-effect-overview
i-walker May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions arrow-site/docs/docs/core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,14 @@ boilerplate and enable direct syntax including [monad comprehensions and computa

</div>

<div class="quickstart-coroutines-item" markdown="1">
#### Continuations and programs
- [Effect]({{ '/apidocs/arrow-core/arrow.core.continuations/-effect/' | relative_url }})
- [EffectScope]({{ '/apidocs/arrow-core/arrow.core.continuations/-effect-scope/' | relative_url }})
- [EagerEffect]({{ '/apidocs/arrow-core/arrow.core.continuations/-eager-effect/' | relative_url }})
- [EagerEffectScope]({{ '/apidocs/arrow-core/arrow.core.continuations/-eager-effect-scope/' | relative_url }})
</div>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any idea how this impacts the website when we add a 5th div?

I'm also fine if we re-org Quick Start & Extensions and data types so that we can keep the same layout with 4 divs on the page. Adding a 5th div might impact the design/layout from the website a lot.

cc\ @israelperezglez @franciscodr @raulraja

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could have it under the same div as Extension and data, if that makes sense ?

Copy link
Member

@raulraja raulraja May 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@i-walker can you provide a screenshot of what these changes look like before merging? ideally, we could have a build action that when selectively triggered for a commit hash temporarily deployed the site until the PR is merged.

<div class="quickstart-coroutines-item" markdown="1">
#### Tutorials
- [Error Handling]({{ '/patterns/error_handling/' | relative_url }})
Expand Down