deprecate signatures in computations and add Result for continuations #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-walker
commented
Feb 22, 2022
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/continuations/result.kt
Outdated
Show resolved
Hide resolved
nomisRev
reviewed
Feb 22, 2022
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/continuations/result.kt
Outdated
Show resolved
Hide resolved
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/computations/either.kt
Outdated
Show resolved
Hide resolved
| public inline fun <A> eager(crossinline func: suspend RestrictedEvalEffect<A>.() -> A): Eval<A> = | ||
| Effect.restricted(eff = { RestrictedEvalEffect { it } }, f = func, just = Eval.Companion::now) | ||
|
|
||
| @Deprecated(deprecateInFavorOfEffect, ReplaceWith("effect(func)", "arrow.core.continuations.effect")) |
There was a problem hiding this comment.
👍, this deprecation will allows us to get rid of the confusing eval { } block 🥳
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/computations/nullable.kt
Outdated
Show resolved
Hide resolved
| public inline fun <E, A> eager(crossinline c: suspend RestrictedEitherEffect<E, *>.() -> A): Either<E, A> = | ||
| Effect.restricted(eff = { RestrictedEitherEffect { it } }, f = c, just = { it.right() }) | ||
|
|
||
| @Deprecated(deprecateInFavorOfEffect, ReplaceWith("either(c)", "arrow.core.continuations.either")) |
i-walker
commented
Feb 23, 2022
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/continuations/nullable.kt
Outdated
Show resolved
Hide resolved
nomisRev
reviewed
Feb 24, 2022
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/computations/nullable.kt
Outdated
Show resolved
Hide resolved
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/computations/nullable.kt
Outdated
Show resolved
Hide resolved
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/computations/nullable.kt
Outdated
Show resolved
Hide resolved
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/computations/nullable.kt
Outdated
Show resolved
Hide resolved
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/computations/nullable.kt
Outdated
Show resolved
Hide resolved
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/computations/nullable.kt
Outdated
Show resolved
Hide resolved
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/computations/nullable.kt
Outdated
Show resolved
Hide resolved
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/continuations/option.kt
Outdated
Show resolved
Hide resolved
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/continuations/option.kt
Outdated
Show resolved
Hide resolved
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/continuations/result.kt
Outdated
Show resolved
Hide resolved
…mputations/nullable.kt Co-authored-by: Simon Vergauwen <[email protected]>
…mputations/nullable.kt Co-authored-by: Simon Vergauwen <[email protected]>
…mputations/nullable.kt Co-authored-by: Simon Vergauwen <[email protected]>
Co-authored-by: Simon Vergauwen <[email protected]>
nomisRev
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am deprecating the computations module in a seperate PR
resolves #2669 by deprecation