Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Optics] Show error for generic classes in KSP plug-in #2636

Merged
merged 1 commit into from
Jan 12, 2022
Merged

[Optics] Show error for generic classes in KSP plug-in #2636

merged 1 commit into from
Jan 12, 2022

Conversation

serras
Copy link
Member

@serras serras commented Jan 12, 2022

No description provided.

raulraja
raulraja approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @serras !

arrow-libs/optics/arrow-optics-ksp-plugin/src/jvmTest/kotlin/arrow/optics/plugin/LensTests.kt
@@ -32,4 +33,34 @@ class LensTests {
|val r = i != null
""".evals("r" to true)
}

@Test
fun `Lenses which mentions imported elements`() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@serras serras merged commit a12a883 into main Jan 12, 2022
@i-walker i-walker mentioned this pull request Jan 14, 2022
Merged
@serras serras deleted the ksp-optics-generics branch July 3, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomisRev nomisRev nomisRev approved these changes

@raulraja raulraja raulraja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serras @raulraja @nomisRev