Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non throwing Retrofit Either adapter #2621

Merged
merged 30 commits into from
Feb 17, 2022
Merged

Non throwing Retrofit Either adapter #2621

merged 30 commits into from
Feb 17, 2022

Commits on Dec 18, 2021

  1. Add EitherCallAdapter handling network errors

    @lukaszkalnik
    lukaszkalnik committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    88b53c7 View commit details
    Browse the repository at this point in the history

  2. Rename new adapter factory to NetworkEitherCallAdapterFactory; code c… 

    …leanup
    @lukaszkalnik
    lukaszkalnik committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    0bfe2d5 View commit details
    Browse the repository at this point in the history

  3. Rename file to NetworkEitherCallAdapter.kt; add documentation

    @lukaszkalnik
    lukaszkalnik committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    38a4543 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2021

  1. Use existing Factory to return new NetworkEitherCallAdapter

    @lukaszkalnik
    lukaszkalnik committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    e7910a7 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2021

  1. Rename NetworkError to IOError; fix tests

    @lukaszkalnik
    lukaszkalnik committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    c283d28 View commit details
    Browse the repository at this point in the history

  2. Add documentation for NetworkEitherCallAdapter

    @lukaszkalnik
    lukaszkalnik committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    98b958f View commit details
    Browse the repository at this point in the history

  3. Add tests for returning Unit; use new server instance for every test

    @lukaszkalnik
    lukaszkalnik committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    305a115 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2021

  1. Improve documentation syntax

    @lukaszkalnik
    lukaszkalnik committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    175cde3 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary throwable argument from CallError hierarchy

    @lukaszkalnik
    lukaszkalnik committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    ab32c82 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary TimeoutError type

    @lukaszkalnik
    lukaszkalnik committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    6c4e381 View commit details
    Browse the repository at this point in the history

  4. Disconnect at start in test

    @lukaszkalnik
    lukaszkalnik committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    15303a7 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into non-throwing-retrofit-adapter

    @lukaszkalnik
    lukaszkalnik committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    b4155fe View commit details
    Browse the repository at this point in the history

  6. Generate code example with Knit

    @lukaszkalnik
    lukaszkalnik committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    37ded0a View commit details
    Browse the repository at this point in the history

  7. Extend code example to include how to define response type for null r… 

    …esponse body
    @lukaszkalnik
    lukaszkalnik committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    1961a79 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2022

  1. Merge branch 'main' into non-throwing-retrofit-adapter

    @lukaszkalnik
    lukaszkalnik committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    f55bffb View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. Add missing imports in the Knit example for NetworkEitherCallAdapter

    @lukasz-kalnik-gcx
    lukasz-kalnik-gcx committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    ff4293d View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. Fix ResponseE example snippet and restructure KDoc for more clarity

    @lukaszkalnik
    lukaszkalnik committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    8b0c3b8 View commit details
    Browse the repository at this point in the history

  2. Add test when service method returns Unit and non-null body received

    @lukaszkalnik
    lukaszkalnik committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    7cdab13 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into non-throwing-retrofit-adapter

    @lukaszkalnik
    lukaszkalnik committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    7ed2119 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Make IOError contained cause more specific as IOException

    @lukaszkalnik
    lukaszkalnik committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    8fc54bb View commit details
    Browse the repository at this point in the history

  2. Change NetworkEitherCallAdapterTest to a factory parameterized by dif… 

    …ferent JSON converters
    @lukaszkalnik
    lukaszkalnik committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    3f03106 View commit details
    Browse the repository at this point in the history

  3. Add tests for Kotlinx.serialization converter

    @lukaszkalnik
    lukaszkalnik committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    e12ad92 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into non-throwing-retrofit-adapter

    @lukaszkalnik
    lukaszkalnik committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    fc439d4 View commit details
    Browse the repository at this point in the history

  5. Explicitly check the type of wrapped CallError in tests to compensa… 

    …te for type erasure
    @lukaszkalnik
    lukaszkalnik committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    1a55090 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. Remove misleading comment

    @lukaszkalnik
    lukaszkalnik committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    1a3a9cd View commit details
    Browse the repository at this point in the history

  2. Add message to HttpError; use !! on errorBody

    @lukaszkalnik
    lukaszkalnik committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    c2e2228 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into non-throwing-retrofit-adapter

    @lukaszkalnik
    lukaszkalnik committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    923541c View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Merge branch 'main' into non-throwing-retrofit-adapter

    @nomisRev
    nomisRev authored Feb 8, 2022
    Configuration menu
    Copy the full SHA
    f102c4c View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Merge branch 'main' into non-throwing-retrofit-adapter

    @lukaszkalnik
    lukaszkalnik committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    d151017 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2022

  1. Merge branch 'main' into non-throwing-retrofit-adapter

    @raulraja
    raulraja authored Feb 17, 2022
    Configuration menu
    Copy the full SHA
    fd6f0e4 View commit details
    Browse the repository at this point in the history