-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Gradle layout, + KNIT, - ANK and fix site code fences #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # gradle/libs.versions.toml
raulraja
changed the title
[DRAFT] Add knit
Simplify Gradle layout, + KNIT, - ANK and fix site code fences
Nov 29, 2021
i-walker
reviewed
Nov 29, 2021
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Ior.kt
Outdated
Show resolved
Hide resolved
i-walker
reviewed
Nov 30, 2021
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Either.kt
Outdated
Show resolved
Hide resolved
i-walker
reviewed
Nov 30, 2021
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Option.kt
Outdated
Show resolved
Hide resolved
nomisRev
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
i-walker
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏾 Nice
franciscodr
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a joint effort with @JavierSegoviaCordoba and @nomisRev.
build/_site
which is where Ank was postprocessing thedocs
folder. @franciscodr We need you to please review the publishing workflow as the nesting in the docs does not exist anymore and most likely all steps related to removing the index file and copying the different versions need paths adjustments. I did my best but I don't understand how that works and I have no way to test it. Before this gets merged we need this final commit by @franciscodr ensuring the publishing of the site is going to work.