Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web update #2376

Closed
wants to merge 49 commits into from
Closed

Web update #2376

wants to merge 49 commits into from

Conversation

israelperezglez
Copy link
Contributor

@israelperezglez israelperezglez commented Apr 21, 2021 •
edited
Loading

@raulraja @rachelcarmena could you review this PR please?

I have sent the following changes:

  • Dropdown for the home page (47 Degrees + Instill)
  • Quickstart text animation Typewriter Effect
  • Quickstart documentation

@rachelcarmena rachelcarmena mentioned this pull request Apr 22, 2021
Closed
@47degdev
Copy link

47degdev commented May 5, 2021

Task linked: CU-9rrekz Arrow Web Review

rachelcarmena
rachelcarmena approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@rachelcarmena rachelcarmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @israelperezglez 👏 I love it!!!!!!!!! 🙌

@israelperezglez
Copy link
Contributor Author

Thanks @rachelcarmena! 🙌

@israelperezglez israelperezglez changed the title Web update (WIP) Web update May 5, 2021
@israelperezglez israelperezglez marked this pull request as draft May 7, 2021 08:21
@israelperezglez israelperezglez requested review from raulraja and removed request for raulraja May 7, 2021 08:22
@rachelcarmena rachelcarmena self-requested a review May 21, 2021 11:45
@israelperezglez
Copy link
Contributor Author

israelperezglez commented Jun 4, 2021 •
edited
Loading

Folks, here is a summary of the changes we have been making in the PR:

Home

  • Text for Quickstart and typewriter animation
  • Dropdown for training

Doc

  • We have added a new sidebar with different links for Quickstart
  • Modular libraries
  • Tab panel for Gradle and Maven setup
  • New theme for Codemirror and Highlight.js
  • New font-face for code: Jetbrains Mono NL
  • New wrapper in the doc that marks the content in a max-width
  • New styles for html elements that we use in markdown
  • Responsive review

Comments

  1. Core's Quickstart has no content right now (it has the one we created for Quickstart).I've used it to add two blockquotes styles so that they can be used in the doc.

  2. Meta: We've talked about unifying it under the arrow-site repo.

Thanks @rachelcarmena for your feedback all the time ;)

@israelperezglez israelperezglez marked this pull request as ready for review June 4, 2021 09:25
rachelcarmena
rachelcarmena reviewed Jun 4, 2021
View reviewed changes
arrow-libs/core/arrow-meta/build.gradle
Comment on lines -33 to -36
if (!toolsJar)
throw new GradleException("tools.jar not found at your JAVA_HOME dir ${Jvm.current().getJavaHome().getAbsolutePath()}.\n" +
"Building with a JRE or JDK9 is currently not supported.")
testCompileOnly files(toolsJar)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note to remember recovering this local "fix" for your local env.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @rachelcarmena ;)

rachelcarmena
rachelcarmena approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@rachelcarmena rachelcarmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @israelperezglez , thank you so much!! 👏

I just added tiny changes and I realized that the area for the content page is reduced now. I find it difficult to read the tables now because the scroll appears at the end. Please, could it be possible to increase that area? And maybe the wrapping makes sense to avoid issues with long tables.

That's all!! Thank you soooo much!!

Screenshot

@israelperezglez
Copy link
Contributor Author

Awesome @israelperezglez , thank you so much!! 👏

I just added tiny changes and I realized that the area for the content page is reduced now. I find it difficult to read the tables now because the scroll appears at the end. Please, could it be possible to increase that area? And maybe the wrapping makes sense to avoid issues with long tables.

That's all!! Thank you soooo much!!

Screenshot

Raquel is already updated, you can test the wrapper now at 100%. ;)

@rachelcarmena rachelcarmena force-pushed the web-update branch 4 times, most recently from 26cd22c to 6df9b4e Compare June 24, 2021 10:10
israelperezglez and others added 24 commits June 24, 2021 15:15
@israelperezglez @rachelcarmena
responsive
5309ac5
@israelperezglez @rachelcarmena
Update arrow-site/docs/_data/sidebar-quickstart.yml
70f2e50 
Co-authored-by: Rachel M. Carmena <[email protected]>
@israelperezglez @rachelcarmena
Update arrow-site/docs/_data/sidebar-quickstart.yml
08e4f03 
Co-authored-by: Rachel M. Carmena <[email protected]>
@israelperezglez @rachelcarmena
Update arrow-site/docs/_includes/_nav.html
e30ef8b 
Co-authored-by: Rachel M. Carmena <[email protected]>
@israelperezglez @rachelcarmena
Update arrow-site/docs/docs/quickstart/README.md
0fb8f60 
Co-authored-by: Rachel M. Carmena <[email protected]>
@israelperezglez @rachelcarmena
Update arrow-site/docs/docs/quickstart/README.md
27bac59 
Co-authored-by: Rachel M. Carmena <[email protected]>
@israelperezglez @rachelcarmena
updated
9519744
@israelperezglez @rachelcarmena
updated
79dfb5e
@israelperezglez @rachelcarmena
table wrap
2d7f383
@israelperezglez @rachelcarmena
brand 47 footer
eddf735
@israelperezglez @rachelcarmena
gradle groovy
4087cb9
@israelperezglez @rachelcarmena
theme light code
07d3f35
@israelperezglez @rachelcarmena
brand docs
42b0a87
@israelperezglez @rachelcarmena
sponsored by doc header
c47dc0a
@israelperezglez @rachelcarmena
edit page
bd4177d
@rachelcarmena
Revert "edit page"
2b73a84 
This reverts commit 2858db4.
@israelperezglez @rachelcarmena
edit page
88d5510
@rachelcarmena
Dokka: Fix source link
b43dff9
@rachelcarmena
Add link to Edit Page button
888b268
@rachelcarmena
Custom Jekyll plugin to add button from source link
17b8b3b
@rachelcarmena
Update Setup content
7e1e748
@rachelcarmena
Update arrow-site/docs/_data/sidebar-quickstart.yml
3265507
@rachelcarmena
Relative URLs for img, css and js
101a8e4
@rachelcarmena
Format
dc33480
@raulraja raulraja mentioned this pull request Jul 29, 2021
Closed
@franciscodr
Copy link
Collaborator

Closing this pull request in favor of #2477

@franciscodr franciscodr closed this Sep 6, 2021
@franciscodr franciscodr deleted the web-update branch April 21, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelcarmena rachelcarmena rachelcarmena approved these changes

@raulraja raulraja Awaiting requested review from raulraja

@franciscodr franciscodr Awaiting requested review from franciscodr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@israelperezglez @47degdev @franciscodr @rachelcarmena