Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead link in menu of arrow-kt.io #2523

Closed
rybak opened this issue Sep 21, 2021 · 5 comments
Closed

Dead link in menu of arrow-kt.io #2523

rybak opened this issue Sep 21, 2021 · 5 comments

Comments

@rybak
Copy link

rybak commented Sep 21, 2021

Steps to reproduce

  1. Go to https://arrow-kt.io/docs/typeclasses/intro/
  2. On the left, click on "Docs"

Actual result

Expected result

  • Link leads to an existing location

Side note: I couldn't find separate repository for the website at https://github.com/arrow-kt, I assume that https://github.com/arrow-kt/arrow/issues is the correct place for reporting issues with the website. Please correct me if I'm wrong.

@fo2rist
Copy link
Contributor

fo2rist commented Feb 8, 2022

Check if that's a sufficient fix #2664
I'm not the author, but it seems to be similar to what it should to be

@nomisRev
Copy link
Member

nomisRev commented Feb 8, 2022

Thank you for the PR @fo2rist 🙏

@rybak
Copy link
Author

rybak commented Feb 8, 2022

@fo2rist I doubt that README.md in the root directory has anything to do with links in the side menu on pages of https://arrow-kt.io/ So saying "Closes #2523" in your pull request is misleading.


In the mean time, original bug description:

Steps to reproduce

  1. Go to https://arrow-kt.io/docs/typeclasses/intro/
  2. On the left, click on "Docs"

Actual result

is outdated. Page https://arrow-kt.io/docs/typeclasses/intro/ no longer exists. And if you go to any existing page, e.g. https://arrow-kt.io/docs/core/, the "Docs" link no longer exists. Instead, the side menu on the left has "Api Docs" [sic] link, which leads to https://arrow-kt.io/docs/apidocs/arrow-core/arrow.core/ which does exist. So I assume that my original bug report got addressed in some other pull request.

@rybak rybak closed this as completed Feb 8, 2022
@rybak
Copy link
Author

rybak commented Feb 8, 2022

I believe that the original bug got resolved by PR #2477, since its diff includes this change in file arrow-site/docs/_data/sidebar-core.yml:

-  - title: Docs
-    url: /apidocs/arrow-core/
+  - title: Api Docs
+    url: /apidocs/arrow-core/arrow.core

@fo2rist
Copy link
Contributor

fo2rist commented Feb 8, 2022

Thanks! You're right, I've mixed up two different things.
Will remove the link between PR and the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants