Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update route to compiler plug-ins #38

Merged
merged 5 commits into from
May 9, 2022
Merged

Update route to compiler plug-ins #38

merged 5 commits into from
May 9, 2022

Conversation

serras
Copy link
Member

@serras serras commented Apr 7, 2022

Fixes #36

Alas, the compiler does not run in the laws and example projects (you can see this by inspecting the JAR created for laws and seeing that no @Pre or @Post annotations are present). Any ideas on how to fix this? @raulraja @i-walker @nomisRev

@serras
Copy link
Member Author

serras commented Apr 7, 2022

But weirdly it does run in CI :/

@serras
Copy link
Member Author

serras commented Apr 7, 2022

After digging a bit more I'm suspecting that this might be related to the versioning plug-in. In my local system I get weird versions like 2.0.2-SNAPSHOT-<date>+<time>Z, whereas in CI they are much simpler.

Is there a way to see whether this is the case? Maybe changing some configuration in the versioning plug-in? @i-walker

@JavierSegoviaCordoba
Copy link
Member

After digging a bit more I'm suspecting that this might be related to the versioning plug-in. In my local system I get weird versions like 2.0.2-SNAPSHOT-<date>+<time>Z, whereas in CI they are much simpler.

Is there a way to see whether this is the case? Maybe changing some configuration in the versioning plug-in? @i-walker

The date you are getting is because you have something modified in local. If you commit those files you will get a specific version based on the commit hash.

@serras
Copy link
Member Author

serras commented Apr 7, 2022

That means that I can only test the project with a clean Git status?

@i-walker
Copy link
Member

i-walker commented Apr 7, 2022

Yes @serras, that is the case for most arrow projects if you depend on build output

@JavierSegoviaCordoba JavierSegoviaCordoba marked this pull request as ready for review April 7, 2022 11:49
@JavierSegoviaCordoba
Copy link
Member

JavierSegoviaCordoba commented Apr 7, 2022

I can add a feature to the version plugin to force a hash version even without a clean status so we can test locally without having to commit files.

For example:

./gradlew -Psemver.useTimestamp=false

@serras
Copy link
Member Author

serras commented Apr 7, 2022

That would be wonderful :)

@JavierSegoviaCordoba
Copy link
Member

JavierSegoviaCordoba commented May 7, 2022

@serras curiously I had that property already implemented with another name and I totally forget it 😆

The usage is:

./gradlew -Psemver.checkClean=false

@serras
Copy link
Member Author

serras commented May 9, 2022

It worked! @JavierSegoviaCordoba thanks for the hint :)

@serras serras merged commit c0d40f9 into main May 9, 2022
@serras serras deleted the as-pick-plugin branch May 9, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken path
3 participants