[CentralDashboard v2] Added env_var for KFAM Server address (kubeflow…

…#298) * Added an environment variable to central dash to target the correct KFAM target * Addresed PR comments and updated tests
arrikto · Aug 22, 2019 · 2e42975 · 2e42975
1 parent 6ed96fd
commit 2e42975
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/common/centraldashboard/base/deployment.yaml b/common/centraldashboard/base/deployment.yaml
@@ -26,4 +26,6 @@ spec:
           value: $(userid-header)
         - name: USERID_PREFIX
           value: $(userid-prefix)
+        - name: PROFILES_KFAM_SERVICE_HOST
+          value: profiles-kfam.kubeflow
       serviceAccountName: centraldashboard
diff --git a/tests/centraldashboard-base_test.go b/tests/centraldashboard-base_test.go
@@ -76,6 +76,8 @@ spec:
           value: $(userid-header)
         - name: USERID_PREFIX
           value: $(userid-prefix)
+        - name: PROFILES_KFAM_SERVICE_HOST
+          value: profiles-kfam.kubeflow
       serviceAccountName: centraldashboard
 `)
 	th.writeF("/manifests/common/centraldashboard/base/role-binding.yaml", `

diff --git a/tests/centraldashboard-overlays-application_test.go b/tests/centraldashboard-overlays-application_test.go
@@ -145,6 +145,8 @@ spec:
           value: $(userid-header)
         - name: USERID_PREFIX
           value: $(userid-prefix)
+        - name: PROFILES_KFAM_SERVICE_HOST
+          value: profiles-kfam.kubeflow
       serviceAccountName: centraldashboard
 `)
 	th.writeF("/manifests/common/centraldashboard/base/role-binding.yaml", `

diff --git a/tests/centraldashboard-overlays-istio_test.go b/tests/centraldashboard-overlays-istio_test.go
@@ -114,6 +114,8 @@ spec:
           value: $(userid-header)
         - name: USERID_PREFIX
           value: $(userid-prefix)
+        - name: PROFILES_KFAM_SERVICE_HOST
+          value: profiles-kfam.kubeflow
       serviceAccountName: centraldashboard
 `)
 	th.writeF("/manifests/common/centraldashboard/base/role-binding.yaml", `