ArrayFire bindings for Linear Algebra #3
Conversation
| RDoc::Task.new do |rdoc| | ||
| rdoc.main = "README.md" | ||
| rdoc.rdoc_files.include(%w{README.md LICENSE CONTRIBUTING.md lib ext}) | ||
| end |
There was a problem hiding this comment.
Will this task run if you do a gem build on the gemspec? Is it not possible to add this to the gemspec itself?
There was a problem hiding this comment.
@v0dro I didn't get the question. Why would we need rdoc to run when using gem build.?
AFAIK, RubyDoc.info automatically generates the docs when I push the gem.
There was a problem hiding this comment.
So the above rake commands adds rdoc files which are then read by rubygems.org to generate YARD docs. If its not done during gem build and if you forget to run above rake task, the rdoc files will not get added to the gemspec and rubygems wont be able to detect them.
There was a problem hiding this comment.
@v0dro, I will follow Victor's advice about using rubygems-tasks library.
ext/mri/cmodules/arith.c
Outdated
| return Data_Wrap_Struct(CLASS_OF(left_val), NULL, arf_free, result); \ | ||
| } | ||
|
|
||
| #define DEF_UNARY_RUBY_ACCESSOR(oper, name) \ |
ext/mri/cmodules/device.c
Outdated
| static VALUE arf_device_info(VALUE self, VALUE name_val, VALUE platform_val, VALUE toolkit_val, VALUE compute_val){ | ||
| char* d_name = (char*)malloc(sizeof(char) * 64); | ||
| char* d_platform = (char*)malloc(sizeof(char) * 10); | ||
| char* d_toolkit = (char*)malloc(sizeof(char) * 64); |
There was a problem hiding this comment.
Shouldn't you be using xmalloc and xfree everywhere? They're the functions from ruby.h and allocate memory that the ruby VM is aware. malloc will allocate from system heap not ruby VM heap.
|
When do you plan to merge this? |
ext/mri/interfaces/nmatrix.c
Outdated
|
|
||
| af_get_dims(&dims[0], &dims[1], &dims[2], &dims[3], input->carray); | ||
|
|
||
| size_t* shape = (size_t*)malloc(ndims * sizeof(size_t));; |
ext/mri/interfaces/nmatrix.c
Outdated
| uint ndims; | ||
| af_get_numdims(&ndims, input->carray); | ||
|
|
||
| dim_t* dims = (dim_t*)malloc(ndims * sizeof(dim_t)); |
There was a problem hiding this comment.
its good practice in C to declare all the variables at the top of the function.
|
@9prady9 You can merge this PR now :) . |
|
Is it possible to publish this using rubygems? Just |
|
Also you should remove the statement saying that bindings aren't yet ready for production from README. And, add SciRuby to the acknowledgements at the bottom along with the website. |
|
@v0dro I don't think it is a good idea to remove the cautionary statements until all the feasible functionality from ArrayFire is ported over to the ruby bindings. For one, I don't think @prasunanand has worked on image processing functions yet. Also, I believe indexing hasn't been worked on either. |
|
Oh. Ok. @prasunanand can you create issues and set milestones for this purpose in the GitHub issue tracker? It will becomes easy for new contributors to quickly what's going on and how to contribute. Make things as granular as possible. @9prady9 rubygems is the ruby packaging system and the central repository for most open source gems (yes, it is similar to npm and crates). Hosting the gem on rubygems will allow users to install with a single command instead of cloning and compiling. |
|
@prasunanand @v0dro Please use this issue to track progress of implementing left over features. |
|
Alright. I think you add them to @9prady9 's list. |
Implemented following classes:
Added exception handling.
Only doubles implemented currently