Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to trigger the deploy #2297

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Update README.md to trigger the deploy #2297

merged 1 commit into from
Apr 12, 2024

Conversation

shlomodaari
Copy link
Contributor

Resolves GitHub issue:

Resolves Jira: [JIRAPROJECT-123]

@shlomodaari shlomodaari requested a review from a team as a code owner April 12, 2024 18:07
Copy link

armory-io bot commented Apr 12, 2024

PR title: Update README.md to trigger the deploy does not meet Armory Engineering best practices around conventional commits.

Reason: The category was missing. EX: category: description or category(scope): description. Common Categories: build, ci, chore, docs, feat, fix, perf, refactor, revert, style, test, ops

Because we enforce conventional commits and squash merges of PRs, the PR Title becomes the commit title.

<type>[optional scope]: <description> <- The PR title becomes this part.

[optional body] <- You can add this when you merge your PR.

[optional footer] <- You can add this when you merge your PR.

For more information, see the Conventional Commits specification.

Some common examples are:

docs: correct spelling of CHANGELOG
chore!: drop Node 6 from testing matrix
chore(ops)!: drop Node 6 from testing matrix
feat(armory.io): add docs.armory.io
fix(parser): grammar and spelling
style(loadingPage): made it super pretty!
refactor(helpMessages): changed order to make more sense

@shlomodaari shlomodaari merged commit 571d68b into master Apr 12, 2024
8 of 9 checks passed
@shlomodaari shlomodaari deleted the v2.31 branch April 12, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant