fix(rn): fix front matter in release notes #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The leading zero likely had the page being interpreted as a hex number instead of an int, so the orderering from the pages got out of whack (2.30 was listed after 2.28). With the logic on the release notes page, it meant that "28" was considered the latest active patch release and therefore kicked the "30" version into the deprecated section. Also fixed a logical bug in the value setting for this page when we release version 28.0.0 of the product xP
dogonthehorizon
force-pushed
the
fix/2-30-release-notes
branch
from
1174500
to
753af44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leading zero likely had the page being interpreted as a hex number instead of an int, so the orderering from the pages got out of whack (2.30 was listed after 2.28). With the logic on the release notes page, it meant that "28" was considered the latest active patch release and therefore kicked the "30" version into the deprecated section. Also fixed a logical bug in the value setting for this page when we release version 28.0.0 of the product xP
Resolves GitHub issue:
Resolves Jira: [JIRAPROJECT-123]