Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quickSpin): Updated link for quick-spin compose to use oss. #1878

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DanielaS12
Copy link
Contributor

@DanielaS12 DanielaS12 commented Feb 27, 2023

Resolves Jira: SPLAT-434

@DanielaS12 DanielaS12 requested a review from a team as a code owner February 27, 2023 13:04
@armory-jenkins
Copy link
Contributor

The title of this Pull Request needs to be changed to match the format:

<type>(<scope>): <subject>

See more details here: https://www.spinnaker.io/community/contributing/submitting/#commit-message-conventions

Some common examples are:

feat(armory.io): add docs.armory.io
fix(parser): grammar and spelling
style(loadingPage): made it super pretty!
refactor(helpMessages): changed order to make more sense

@DanielaS12 DanielaS12 changed the title feat(quick-spin):Updated link for quick-spin compose to use oss. feat(quickSpin):Updated link for quick-spin compose to use oss. Feb 27, 2023
@DanielaS12 DanielaS12 changed the title feat(quickSpin):Updated link for quick-spin compose to use oss. feat(quickSpin): Updated link for quick-spin compose to use oss. Feb 27, 2023
@mrampton
Copy link
Contributor

Let's hold off on merging this until:

  1. We should actually provide details for both versions of quick-spin (oss and armory)
  2. We should have the quick-spin repo building properly

@aimeeu aimeeu marked this pull request as draft February 27, 2023 18:43
@aimeeu
Copy link
Contributor

aimeeu commented Feb 27, 2023

Let's hold off on merging this until:

  1. We should actually provide details for both versions of quick-spin (oss and armory)
  2. We should have the quick-spin repo building properly

I added a "do not merge" label and also changed to "draft" status so I don't accidentally merge the PR.

@armory armory deleted a comment from armory-jenkins Feb 27, 2023
@armory armory deleted a comment from armory-jenkins Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants