New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corrected Serve() unreachable code in socks5.go #18

Open

patrickToca wants to merge 4 commits into armon:master from patrickToca:hotfix/unreachable

patrickToca commented May 23, 2017

running Vet indicated an unreachable code in Serve().

I propose this correction, a simple remove of the 'return nil' could do as well.

patrickToca added 4 commits

May 23, 2017 13:35


          corrected Serve() unreachable code in socks5.go

1e5c0b5


          qualified type as 'net.Conn' in Serve()

7aae60b


          back to 'golang.org/x/net/context'

f7a56ec


          Serve() return error completed

b20f9b8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet