Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Docker 25.1.x+ image export from OCI format to legacy format. #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

romaincabassot
Copy link

@romaincabassot romaincabassot commented Jul 5, 2024

Since Docker 25.1.x image export is done in OCI format which is not supported by the clair-local-scan image which bundles an old CLAIR version.

It requires you to have skopeo binary somewhere in your system and the this tool has a recent version. If skopeo is not in the PATH, use SKOPEO_BIN_PATH environment variable to point to the executable.

Skopeo is used to transform the docker image to legacy format.

Dev has been tested with old and new Docker versions.

@romaincabassot romaincabassot changed the title Convert Docker 24.1.x+ image export from OCI format to legacy format. Convert Docker 25.1.x+ image export from OCI format to legacy format. Jul 5, 2024
@cpuguy83
Copy link

cpuguy83 commented Jul 5, 2024

I assume the old scanner is assuming that things are in specific paths in the tarball?
Why not update the scanner image to read the tarball based on manifest.json?

@romaincabassot
Copy link
Author

Because I don't know the internals of clair server and the in-use version is very old so I though it would have been a too big step for me but I'm certain it would have been a better option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants