Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add itc type to hdmirx #262

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

benhoff
Copy link
Contributor

@benhoff benhoff commented Oct 11, 2024

This backports the ability to check the ITC type.

@amazingfate
Copy link
Collaborator

I just tested your patch on rock5b and 6.11 mainline kernel, obs is not working. After removing your patch obs is fine.
I guess this would also break vendor kernel.

@benhoff
Copy link
Contributor Author

benhoff commented Oct 12, 2024

I just tested your patch on rock5b and 6.11 mainline kernel, obs is not working. After removing your patch obs is fine. I guess this would also break vendor kernel.

@amazingfate Thanks for testing!

It's running on the vendor kernel for me, but with my own custom v4l2 application, I hadn't tested obs as I'm not running a desktop.

Can you help me understand the environment you are testing it in so I can recreate?

I'm surprised you can run drivers from 6.1 on 6.11, but I don't do a lot of kennel development so that's why I'm asking.

I'll spin up an environment and get to the bottom of obs here in a few days

@amazingfate
Copy link
Collaborator

I was testing mainline kernel with your commit yesterday.
I get error: v4l2-input: /dev/video0: select timed out when adding v4l2 device to obs. I'm running armbian noble.
Debian has broken obs because they add this patch: https://salsa.debian.org/multimedia-team/obs-studio/-/commit/4a353a071febf315746a9d184bc6506e31421882, I'm testing obs without this patch.
I tested 6.1 kernel with your patch today and find that there is still select timed out issue without your patch, so your patch should be not related. I will check mainline kernel tomorrow.

@amazingfate
Copy link
Collaborator

This commit is fine, let's merge it.

@amazingfate amazingfate merged commit 96d7091 into armbian:rk-6.1-rkr3 Oct 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants