arm64: dts: rock-5a: pull down data-strobe to fix emmc compatibility #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull down the emmc-data-strobe to fix some emmc compatibility.
amazingfate
approved these changes
Jan 27, 2024
|
I know the Turing RK1 has this problem, it's how the mainline patch was found. If more boards have eMMC troubles in the future, it may be a good idea to enable the patch globally. |
Affected boards appear to have certain resistors omitted from the circuit design. The issue will arise when the onboard eMMC or user-supplied eMMC module is from a specific vendor. Samsung and Kioxia are known to be affected, while FORESEE and SanDisk are very lucky. |
bill88t
pushed a commit
to BredOS/linux-rockchip
that referenced
this pull request
Feb 19, 2024
Radxa ROCK 3C has one HDMI port supporting CEC and HDMI 2.0 with resolutions up to 1080P@60fps. Signed-off-by: Stephen Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainline has enabled this globally for all 3588 boards. I'm not sure if this is a good idea for the BSP kernel as well.
So only enable it on Rock-5a which is known to be affected.