Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64: dts: Add support for roc-rk3588s-pc #123

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

zouxf
Copy link
Contributor

@zouxf zouxf commented Nov 30, 2023

roc_rk3588s_pc is a RK3588S-based board, the vendor is firefly, the mini-pc station-m3 is based on this board.

@amazingfate
Copy link
Collaborator

rk3588s-roc-rk3588s-pc-v12.dts and rk3588s-roc-rk3588s-pc-v12.dtsi are sharing the same name, so why split them into two files?

@zouxf
Copy link
Contributor Author

zouxf commented Nov 30, 2023

Since there is also a v13 for the roc-rk3588s-pc, in the future I would like the dts for v13 to include the v12.dtsi and the differences from v12. It sounds like using v12.dtsi as a base dtsi and the dts file including this file and the differences to v12.dtsi.

@amazingfate
Copy link
Collaborator

What about using a singe rk3588s-roc-rk3588s-pc-v12.dts for v12 board, and include it in the future v13?

@zouxf
Copy link
Contributor Author

zouxf commented Nov 30, 2023

Okay, I'll fix this. Thank you!

@amazingfate amazingfate merged commit 17a4afb into armbian:rk-5.10-rkr6 Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants